-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CuYao an extension #494
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 89.03% 88.75% -0.29%
==========================================
Files 83 87 +4
Lines 4835 5264 +429
==========================================
+ Hits 4305 4672 +367
- Misses 530 592 +62 ☔ View full report in Codecov by Sentry. |
@Roger-luo all tests pass except the nightly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is CUDA current being tested in CI? I don't see any test being setup in the CI?
[compat] | ||
BitBasis = "0.8, 0.9" | ||
CUDA = "4, 5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we actually support both versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? We can remove it later if its not compatible anymore.
I haven't setup the CI yet, we need to test locally. We do not have tests for CuYao for long time. |
@@ -7,6 +7,7 @@ FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341" | |||
KrylovKit = "0b1a1467-8014-51b9-945f-bf0ae24f4b77" | |||
Latexify = "23fbe1c1-3f47-55db-b15f-69d7ec21a316" | |||
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306" | |||
LiveServer = "16fef848-5104-11e9-1b77-fb7a48bbb589" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we actually need this to build the doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is just convenient, otherwise you will have to start a temp environment and install LiveServer. Do you have a better option? Now the workflow is
make init-docs # initialize the docs environment
make servedocs # live serve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just use a separate Project.toml
file for dev only within .ci
directory. So you can keep the main environment clean. This is where I hate the stack env design... but LiveServer is not that big to download so prob fine if you insist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. We can fix this issue in the future when this workflow causes any trouble.
Instead of installing CuYao, the CUDA extension can be access by typing
To test the CUDA extension, please run
Some extra make targets are added:
make init
andmake init-docs
to initializeYao
anddocs
environment.make update
andmake update-docs
to update the above environments.make test-<package name>
to test a component package.make test
to test all component packages.make coverage
to test all component packages and generate the coverage files.make
is a combinaton ofmake init
andmake test
make-servedocs
to serve documents.make clean
to clean up document build and.cov
files.Maybe we can remove
.ci
in the future.