Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include YaoPlots as a component package #493

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Feb 20, 2024

List of changes

  1. Include YaoPlots as a component package.
image

The using time increased from 0.68s to 0.9s on my machine.

julia> @time using Yao
  0.901292 seconds (1.28 M allocations: 86.938 MiB, 5.83% gc time, 22.79% compilation time: 94% of which was recompilation)
  1. Fixed some of the documentation.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (e17a32b) 89.03% compared to head (69f1bf5) 88.75%.
Report is 1 commits behind head on master.

Files Patch % Lines
lib/YaoPlots/src/vizcircuit.jl 82.17% 54 Missing ⚠️
src/EasyBuild/block_extension/shortcuts.jl 25.00% 3 Missing ⚠️
lib/YaoPlots/src/bloch.jl 98.03% 2 Missing ⚠️
lib/YaoPlots/src/YaoPlots.jl 66.66% 1 Missing ⚠️
lib/YaoPlots/src/helperblock.jl 94.11% 1 Missing ⚠️
src/EasyBuild/block_extension/FSimGate.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   89.03%   88.75%   -0.29%     
==========================================
  Files          83       87       +4     
  Lines        4835     5264     +429     
==========================================
+ Hits         4305     4672     +367     
- Misses        530      592      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiggleLiu
Copy link
Member Author

GiggleLiu commented Feb 20, 2024

The YaoBlocks test breaks on nightly, which is due to an error in Zygote.

@GiggleLiu GiggleLiu merged commit f660709 into master Feb 21, 2024
20 of 24 checks passed
@GiggleLiu GiggleLiu deleted the jg/include-yaoplots branch February 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants