fix: Saveguard against invalid comparison in pandas comparator (#8)

* saveguard against invalid comparison in pandas comparator * hooks
Quantco · Oct 31, 2024 · 08a5733 · 08a5733
1 parent 326fe0b
commit 08a5733
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/tabulardelta/comparators/pandas_comparator.py b/tabulardelta/comparators/pandas_comparator.py
@@ -290,7 +290,9 @@ def compare_pandas(
                 left, right, float_rtol, float_atol, True
             )
         else:
-            joined[col + "_equal"] = (left == right) | pd.isna(left) & pd.isna(right)
+            joined[col + "_equal"] = (left == right).fillna(False) | pd.isna(
+                left
+            ) & pd.isna(right)
         unequal = joined[~joined[col + "_equal"].astype("bool")]
         change = _value_change(unequal, join_columns, col, suffixes, old_dt, new_dt)
         if len(change) > 0: