User driven getitem and construction #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagoel4512
force-pushed
the
construct-member
branch
from
7c04040
to
1e48baa
Compare
adityagoel4512
force-pushed
the
construct-member
branch
4 times, most recently
from
1bee70d
to
e762a8a
Compare
adityagoel4512
force-pushed
the
construct-member
branch
from
e762a8a
to
d64e966
Compare
cbourjau
reviewed
Aug 26, 2024
adityagoel4512
force-pushed
the
construct-member
branch
from
1ca1db9
to
f89fe11
Compare
adityagoel4512
force-pushed
the
construct-member
branch
from
fbb98d6
to
01f67fd
Compare
cbourjau
approved these changes
Aug 29, 2024
adityagoel4512
force-pushed
the
construct-member
branch
from
ceb7755
to
7254338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array construction is offloaded to the dtype. Previously this assumed all fields are equivalent shape. Nothing should change for existing implementations. User-defined dtypes with representations where fields are not all equivalent shape (e.g. a
List) can now be constructed.getitemis also offloaded to the dtype. Nothing should change here either for existing implementations.I have left
setitemout now. I would like to ensure thatsetitemdoesn't change the dtype of the array being set and do this in a later PR.