-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update array API tests without adding complex number support #37
Conversation
Does this PR supersede #33? |
#39 will address the 1 failure. The ONNX standard doesn't support |
Yes! Sorry for the confusion! |
ae388b0
to
455e502
Compare
Brief update: The latest test suite runs quite fast, allowing us to run on many more hypothesis examples than previously (100 instead of 2 at the time of writing). This did surface some further issues. In particular, I discovered that we can trigger segfaults in |
Nice, thanks! If it's faster now it would be great to have |
The full list of failures as of this writing can be found in the CI of this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few XPASSes.
I'm afraid some of them are just flaky. I generated these files from observed failures. |
I am now running the array-api-tests using a fixed seed. Thus, we should no longer get flaky XPASSes. I think this is now ready to merge even if we xfail a lot of tests liberally. We should address these in follow up PRs, IMHO. |
Apparently the tests are still a bit flaky :( The XFAILS you just added were passing previously: https://github.com/Quantco/ndonnx/actions/runs/10677594899/job/29593026155#step:5:1263 |
I'm not sure how much marginal value there is in 100 iterations of each test compared to around 20. I'd rather make it 20 and have super snappy CI again. |
a8b66c2
to
1d5ba89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced the number of repetitions to 16 in the interest of having sub 10 minute CI. I think we can increase it once we've pruned down the list to catch more obscure edge cases but there is a reasonable amount to do as is. The added xfails
are a little concerning but we can come back to them in a future PR.
This PR updates the array API test suite to the latest upstream version
plus a minor custom fix that is in the process of being upstreamed(upstream merged the fix). The fix allows us to run the test suite despite currently not having support for complex numbers, yet (see #32 for more information on adding those).The
skips.txt
file contains failures that cause segfaults in the onnxruntime.xfails.txt
contains test names which fail for other reasons. We should triage both of these files.Edit: Upated the description to reflect the latest circumstance of this PR