Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix true division integer casting. #15

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix true division integer casting. #15

merged 2 commits into from
Jul 11, 2024

Conversation

adityagoel4512
Copy link
Member

@adityagoel4512 adityagoel4512 commented Jul 11, 2024

The Array API standard states that the output of divide must be a floating-point output. This PR ensures that that is the case.

After:

>>> ndx.asarray(2)/3
Array(0.6666666666666666, dtype=Float64)

Before:

>>> ndx.asarray(2)/3
Array(0, dtype=Int64)

@adityagoel4512 adityagoel4512 merged commit f63dd6e into main Jul 11, 2024
16 checks passed
@adityagoel4512 adityagoel4512 deleted the true-div-fix branch July 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants