Refactor where into CoreOperationsImpl and NullableOperationsImpl

ndonnx/_core/_boolimpl.py

@@ -164,14 +164,6 @@ def empty_like(self, x, dtype=None, device=None) -> ndx.Array:
     def nonzero(self, x) -> tuple[Array, ...]:
         return ndx.nonzero(x.astype(ndx.int8))
 
-    @validate_core
-    def where(self, condition, x, y):
-        if x.dtype != y.dtype:
-            target_dtype = ndx.result_type(x, y)
-            x = ndx.astype(x, target_dtype)
-            y = ndx.astype(y, target_dtype)
-        return super().where(condition, x, y)
-
 
 class BooleanOperationsImpl(
     CoreOperationsImpl, _BooleanOperationsImpl, UniformShapeOperations

ndonnx/_core/_coreimpl.py

@@ -48,3 +48,11 @@ def make_nullable(self, x: Array, null: Array) -> Array:
             values=x.copy(),
             null=ndx.broadcast_to(null, nda.shape(x)),
         )
+
+    @validate_core
+    def where(self, condition, x, y):
+        if x.dtype != y.dtype:
+            target_dtype = ndx.result_type(x, y)
+            x = ndx.astype(x, target_dtype)
+            y = ndx.astype(y, target_dtype)
+        return super().where(condition, x, y)

ndonnx/_core/_nullableimpl.py

@@ -27,3 +27,11 @@ def fill_null(self, x: Array, value) -> Array:
     @validate_core
     def make_nullable(self, x: Array, null: Array) -> Array:
         return NotImplemented
+
+    @validate_core
+    def where(self, condition, x, y):
+        if x.dtype != y.dtype:
+            target_dtype = ndx.result_type(x, y)
+            x = ndx.astype(x, target_dtype)
+            y = ndx.astype(y, target_dtype)
+        return super().where(condition, x, y)

ndonnx/_core/_numericimpl.py

@@ -970,14 +970,6 @@ def empty(self, shape, dtype=None, device=None) -> ndx.Array:
     def empty_like(self, x, dtype=None, device=None) -> ndx.Array:
         return ndx.full_like(x, 0, dtype=dtype)
 
-    @validate_core
-    def where(self, condition, x, y):
-        if x.dtype != y.dtype:
-            target_dtype = ndx.result_type(x, y)
-            x = ndx.astype(x, target_dtype)
-            y = ndx.astype(y, target_dtype)
-        return super().where(condition, x, y)
-
 
 class NumericOperationsImpl(
     CoreOperationsImpl, _NumericOperationsImpl, UniformShapeOperations

ndonnx/_core/_stringimpl.py

@@ -70,14 +70,6 @@ def empty(self, shape, dtype=None, device=None) -> ndx.Array:
     def empty_like(self, x, dtype=None, device=None) -> ndx.Array:
         return ndx.zeros_like(x, dtype=dtype, device=device)
 
-    @validate_core
-    def where(self, condition, x, y):
-        if x.dtype != y.dtype:
-            target_dtype = ndx.result_type(x, y)
-            x = ndx.astype(x, target_dtype)
-            y = ndx.astype(y, target_dtype)
-        return super().where(condition, x, y)
-
 
 class StringOperationsImpl(
     CoreOperationsImpl, _StringOperationsImpl, UniformShapeOperations