Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eigen_I] update exercise 1 and answer #548

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

longye-tian
Copy link
Collaborator

Dear John @jstac ,

This pull request is to update the exercise 1 and its answer in eigen_I.md according to #544 .

Best ❤️
Longye

Dear John @jstac ,

This pull request is to update the exercise 1 and its answer in eigen_I.md according to #544 .

Best
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 7b1c179
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/67109ea653f67900080209f5
😎 Deploy Preview https://deploy-preview-548--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 15, 2024

@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 12:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 12:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 12:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 12:59 Inactive
@mmcky
Copy link
Contributor

mmcky commented Aug 20, 2024

thanks @longye-tian.

I see that the plots and diagrams are getting removed. Could this be useful as a second part of the exercise? or have they been removed to enhance clarity?

@longye-tian
Copy link
Collaborator Author

thanks @longye-tian.

I see that the plots and diagrams are getting removed. Could this be useful as a second part of the exercise? or have they been removed to enhance clarity?

Hi Matt,

Yes, from the original question, there is no question related to this diagram, so I removed them for clarity.

As you mentioned, we can also change the original question by adding some questions related to the diagrams I removed. Then, we can add this extra analysis back to the answers.

Best,
Longye

@mmcky
Copy link
Contributor

mmcky commented Oct 11, 2024

@jstac this PR needs an editorial review to see if we want to remove the figures. When you have a chance would you mind to review?

@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:14 Inactive
@mmcky mmcky added the ready label Oct 15, 2024
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 05:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 05:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants