Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intro_supply_demand] Update spellings and example admonitions #543

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

longye-tian
Copy link
Collaborator

@longye-tian longye-tian commented Aug 2, 2024

Dear John @jstac and Matt @mmcky ,

This pull request updates the spellings #532 and example admonitions #520 for intro_supply_demand.md.

In particular, this pull request

  • change 'David Ricado' to 'David Ricardo'
  • change some bold word to italics to match with the style guide.
  • change $f(x) = c + \mathrm{d} x$ to $f(x) = c + d x$, here $d$ is not integrator.
  • add two example admonitions

Best ❤️
Longye

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 197eb55
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66aca06a3370dc000894375b
😎 Deploy Preview https://deploy-preview-543--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 2, 2024

@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 08:52 Inactive
add two example admonitions
@longye-tian longye-tian changed the title [intro_supply_demand] Update typos [intro_supply_demand] Update spellings and example admonitions Aug 2, 2024
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 09:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 09:09 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @longye-tian

@mmcky mmcky marked this pull request as ready for review August 7, 2024 02:07
@mmcky
Copy link
Contributor

mmcky commented Aug 7, 2024

@longye-tian this was marked as draft -- are you still working on this branch?

@longye-tian
Copy link
Collaborator Author

longye-tian commented Aug 7, 2024

@longye-tian this was marked as draft -- are you still working on this branch?

Hi Matt,

Thank you! This pull request is ready to merge now. I forgot to change the status after I add the admonitions 😄

Best,
Longye

@jstac
Copy link
Contributor

jstac commented Aug 7, 2024

Nice work @longye-tian , many thanks.

@jstac jstac merged commit 0774777 into main Aug 7, 2024
7 checks passed
@jstac jstac deleted the example_spelling_2 branch August 7, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants