Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geom_series] Add an exercise #524

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[geom_series] Add an exercise #524

wants to merge 25 commits into from

Conversation

SylviaZhaooo
Copy link
Collaborator

@SylviaZhaooo SylviaZhaooo commented Jul 22, 2024

Dear John @jstac,

Same as before, I changed the last part, the Keynesian model with plots and code snippets part, into an exercise since the logic of this model has been illustrated so it is easy to have the same model as an exercise.

Fixes #401

Best,
Sylvia

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit eb8da1c
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/670dbfcfc5cf6000086ab641
😎 Deploy Preview https://deploy-preview-524--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 22, 2024

@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 04:47 Inactive
@HumphreyYang
Copy link
Collaborator

Hi @mmcky,

I think the connection issue comes up again from the Anaconda side:

  ('Connection broken: IncompleteRead(260439 bytes read, 1980267 more expected)', IncompleteRead(260439 bytes read, 1980267 more expected))

@mmcky
Copy link
Contributor

mmcky commented Jul 22, 2024

thanks @HumphreyYang -- just triggered a rebuild.

lectures/geom_series.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 06:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 06:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 06:44 Inactive
@jstac
Copy link
Contributor

jstac commented Jul 22, 2024

Many thanks @SylviaZhaooo .

Does this pull request address a particular issue? (If yes, then you can put "Fixes #XXX", where XXX is the issue number, and the issue will be closed automatically when this PR is merged.)

Does the reader have enough information to complete the exercise? For example, do they need to know parameter values?

@shlff , could you please review this carefully and work with @SylviaZhaooo to finish it? If I look at https://669dffc4710cf5c7cb257aa4--taupe-gaufre-c4e660.netlify.app/geom_series, it seems that a lot of extra content is included in the solution --- "We now examine what will happen..."

@shlff
Copy link
Member

shlff commented Jul 23, 2024

Thanks @SylviaZhaooo and @jstac .

Hi @SylviaZhaooo I had a look at this PR, and I suggest we break this section into 2 or more exercises

  • 1: plot the time path;
  • 2: plot the time paths with different marginal propensity to consume, or varied investment or different government spending (the second could be broke into parts))

After breaking it down, we then polish the exercise titles and solutions one by one.

@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 07:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 07:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 07:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:57 Inactive
lectures/geom_series.md Outdated Show resolved Hide resolved
taking the values mentioned above.

Next, plot the time paths of $y_t$ with the same initial values but let $g$ take
the values abovementioned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylviaZhaooo not 100% sure which values abovementioned is referring to. Would it be possible to clarify?

Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @shlff and @SylviaZhaooo for this PR. Just a couple of final questions to go.

@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 02:41 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

SylviaZhaooo commented Oct 11, 2024

Hi @mmcky,

I think these are values = [0.3, 0.4] for the comparative analysis just like what we did for i in the first question of the third exercise and I revised the statement and kept it the same as the statement for i.

@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 04:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 04:55 Inactive
@shlff
Copy link
Member

shlff commented Oct 12, 2024

Thanks @SylviaZhaooo and @mmcky .

Hi @SylviaZhaooo , I had a look at the code and I suggested the following modifications to improve the clarity.

You can vote if we should adopt these.

lectures/geom_series.md Outdated Show resolved Hide resolved
lectures/geom_series.md Outdated Show resolved Hide resolved
lectures/geom_series.md Outdated Show resolved Hide resolved
lectures/geom_series.md Outdated Show resolved Hide resolved
lectures/geom_series.md Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 12, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 12, 2024 10:18 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

Hi @shlff,

Thanks for your suggestions! I've reviewed your modifications and committed all the changes. Let me know if there’s anything else you’d like me to adjust or if further improvements are needed.

@shlff
Copy link
Member

shlff commented Oct 13, 2024

Thanks @SylviaZhaooo . It looks better to me now.

If you are happy with it, then we could hand it over to @mmcky for a final review.

Hi @mmcky here is a link to the most recent preview: https://670a4ceac856cc023983ef0f--taupe-gaufre-c4e660.netlify.app/geom_series

@mmcky
Copy link
Contributor

mmcky commented Oct 15, 2024

thanks @shlff and @SylviaZhaooo -- I think this is looking good. 👍

@github-actions github-actions bot temporarily deployed to pull request October 15, 2024 01:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 15, 2024 01:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 15, 2024 02:29 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 15, 2024

@jstac this is ready for final review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[geom_series] Editorial Suggestions
5 participants