Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[equalizing_difference] Add an exercise #522

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

SylviaZhaooo
Copy link
Collaborator

@SylviaZhaooo SylviaZhaooo commented Jul 22, 2024

Dear John @jstac,

I changed the Entrepreneur-worker interpretation part into an exercise and Fixes #385.

Thank @HumphreyYang for providing some other possible exercises.

Best,
Sylvia

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 4add8f4
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66a348172c7a450008a6ef54
😎 Deploy Preview https://deploy-preview-522--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 22, 2024

@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 02:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 02:52 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo -- just a minor change to make a section for Exercises for consistency with other lectures.

lectures/equalizing_difference.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 06:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 22, 2024 06:42 Inactive
@jstac
Copy link
Contributor

jstac commented Jul 22, 2024

Thanks @SylviaZhaooo .

It's important that exercises are completely self-contained, so the student knows exactly what to do. I'm not sure that's the case here. Also, the solution seems to contain discussion not requested in the exercise -- see "Now let’s study how the initial wage premium for successful entrepreneurs depend on the success probability."

@HumphreyYang @mmcky Could you please work with @SylviaZhaooo on this. If the exercise can't be made into something self-contained, then maybe you should close this PR.

@HumphreyYang
Copy link
Collaborator

Many thanks @jstac @SylviaZhaooo.

@SylviaZhaooo I can take over the exercise if you don't mind!

@SylviaZhaooo
Copy link
Collaborator Author

Many thanks @jstac @SylviaZhaooo.

@SylviaZhaooo I can take over the exercise if you don't mind!

Maybe we can talk about this together for some details.

@mmcky
Copy link
Contributor

mmcky commented Jul 23, 2024

@HumphreyYang I just saw your comment. I will leave this open so you can make any edits re: sympy.

@mmcky mmcky requested a review from HumphreyYang July 23, 2024 01:21
@mmcky mmcky added in-work and removed ready labels Jul 23, 2024
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 01:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 01:28 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

@HumphreyYang I revised the exercises by providing more conditions. What do you think of it?

@HumphreyYang
Copy link
Collaborator

@HumphreyYang I revised the exercises by providing more conditions. What do you think of it?

Many thanks @SylviaZhaooo. That's a great improvement! I will make some very small edits and it should be good to go.

@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 13:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 13:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 02:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 02:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 02:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 02:17 Inactive
@HumphreyYang
Copy link
Collaborator

Hi @mmcky,

I think this is ready for your review.

@SylviaZhaooo SylviaZhaooo requested review from mmcky and removed request for HumphreyYang July 24, 2024 05:36
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylviaZhaooo SylviaZhaooo added ready and removed urgent labels Jul 25, 2024
@github-actions github-actions bot temporarily deployed to pull request July 26, 2024 07:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 26, 2024 07:02 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac I think this is ready for your final editorial review.

@HumphreyYang and @SylviaZhaooo have done some nice work updating the exercise.

I think some improvements could be made with the flow -- perhaps helping to setup the exercise and a clear explanation of what the new model will achieve by introducing entrepreneurs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[equalizing_difference] Editorial notes and suggestions
4 participants