-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[equalizing_difference] Add an exercise #522
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SylviaZhaooo -- just a minor change to make a section for Exercises
for consistency with other lectures.
Co-authored-by: Matt McKay <[email protected]>
Thanks @SylviaZhaooo . It's important that exercises are completely self-contained, so the student knows exactly what to do. I'm not sure that's the case here. Also, the solution seems to contain discussion not requested in the exercise -- see "Now let’s study how the initial wage premium for successful entrepreneurs depend on the success probability." @HumphreyYang @mmcky Could you please work with @SylviaZhaooo on this. If the exercise can't be made into something self-contained, then maybe you should close this PR. |
Many thanks @jstac @SylviaZhaooo. @SylviaZhaooo I can take over the exercise if you don't mind! |
Maybe we can talk about this together for some details. |
@HumphreyYang I just saw your comment. I will leave this open so you can make any edits re: sympy. |
@HumphreyYang I revised the exercises by providing more conditions. What do you think of it? |
Many thanks @SylviaZhaooo. That's a great improvement! I will make some very small edits and it should be good to go. |
Hi @mmcky, I think this is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SylviaZhaooo and @HumphreyYang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstac I think this is ready for your final editorial review.
@HumphreyYang and @SylviaZhaooo have done some nice work updating the exercise.
I think some improvements could be made with the flow -- perhaps helping to setup the exercise and a clear explanation of what the new model will achieve by introducing entrepreneurs?
Dear John @jstac,
I changed the Entrepreneur-worker interpretation part into an exercise and Fixes #385.
Thank @HumphreyYang for providing some other possible exercises.
Best,
Sylvia