Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solow] Update unfinished suggestions #511

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

SylviaZhaooo
Copy link
Collaborator

@SylviaZhaooo SylviaZhaooo commented Jul 8, 2024

Dear John @jstac,

I have addressed almost all the suggestions in issue #427. However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Best regards,
Sylvia

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit d783d83
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66a0a72a7bfc2c0008531e1d
😎 Deploy Preview https://deploy-preview-511--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 8, 2024

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 03:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 03:53 Inactive
@SylviaZhaooo SylviaZhaooo requested review from jstac and mmcky July 22, 2024 00:17
@jstac
Copy link
Contributor

jstac commented Jul 22, 2024

Thanks @SylviaZhaooo .

In the lectures we do not combine sentences --- see https://manual.quantecon.org/styleguide/writing.html#general-writing-advice. In particular, we never have a full stop and then continue on the same line.

How about adding this information after the bullet points?

However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Please move that to a separate issue, so we can close #427

@SylviaZhaooo
Copy link
Collaborator Author

Thanks @SylviaZhaooo .

In the lectures we do not combine sentences --- see https://manual.quantecon.org/styleguide/writing.html#general-writing-advice. In particular, we never have a full stop and then continue on the same line.

How about adding this information after the bullet points?

However, I would appreciate your help with the last one, which involves changing the order of two lectures.

Please move that to a separate issue, so we can close #427

Thanks @jstac.

The purpose of saying, "However, I would appreciate your help with the last one, which involves changing the order of two lectures" refers to the last suggestion I want you to check in the last suggestion in issue #427. I think it is a misunderstanding due to my expression, sorry about that. And for the writing style thing, I will be going through the webpage you mentioned. If nothing else is wrong, this pr can be closed.

@mmcky
Copy link
Contributor

mmcky commented Jul 23, 2024

@SylviaZhaooo I can change the order of the two lectures in a separate PR. Let's not incorporate that here.

lectures/solow.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylviaZhaooo I have moved the double sentence to a new line that should appear below the dot points. Once the preview has deployed -- please check it looks good and makes sense.

@SylviaZhaooo
Copy link
Collaborator Author

Thanks @mmcky, I will check it.

@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 07:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 07:07 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

@SylviaZhaooo I can change the order of the two lectures in a separate PR. Let's not incorporate that here.

I see, thanks @mmcky.

@SylviaZhaooo SylviaZhaooo requested review from mmcky and removed request for jstac July 24, 2024 05:59
lectures/solow.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:10 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo

@mmcky mmcky merged commit f5f7161 into main Jul 26, 2024
7 checks passed
@mmcky mmcky deleted the update_solow_second_round branch July 26, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants