-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[solow] Update unfinished suggestions #511
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @SylviaZhaooo . In the lectures we do not combine sentences --- see https://manual.quantecon.org/styleguide/writing.html#general-writing-advice. In particular, we never have a full stop and then continue on the same line. How about adding this information after the bullet points?
Please move that to a separate issue, so we can close #427 |
Thanks @jstac. The purpose of saying, "However, I would appreciate your help with the last one, which involves changing the order of two lectures" refers to the last suggestion I want you to check in the last suggestion in issue #427. I think it is a misunderstanding due to my expression, sorry about that. And for the writing style thing, I will be going through the webpage you mentioned. If nothing else is wrong, this pr can be closed. |
@SylviaZhaooo I can change the order of the two lectures in a separate PR. Let's not incorporate that here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SylviaZhaooo I have moved the double sentence to a new line that should appear below the dot points. Once the preview
has deployed -- please check it looks good and makes sense.
Thanks @mmcky, I will check it. |
I see, thanks @mmcky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SylviaZhaooo
Dear John @jstac,
I have addressed almost all the suggestions in issue #427. However, I would appreciate your help with the last one, which involves changing the order of two lectures.
Best regards,
Sylvia