-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unpleasant] Address Comments on Styles and Improve Citation Style #495
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HumphreyYang this looks great.
The use of cite:t
isn't common across our lectures.
Currently we recommend to use cite
and have updated the default to use author_year
. Does the cite:t
provide different formatting?
Many thanks @mmcky. I think |
thanks @HumphreyYang this is super interesting. @jstac if we want to migrate to The engineer in me has always liked the reference in brackets |
@mmcky @HumphreyYang Regarding cites, that's a tough one. There are cites in other lectures that don't suit this style (should we make a blanket change). See, e.g., https://jax.quantecon.org/aiyagari_jax.html I'd like to stay out of this if I can 😬 |
@HumphreyYang I think my preference would be to use the global
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HumphreyYang this looks great.
Many thanks @HumphreyYang . |
This PR resolves #445.