Update greeksquare lecture with new visualizations
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ddeac33.
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmcky
requested changes
Jun 27, 2024
There was a problem hiding this comment.
thanks @HumphreyYang for these updates.
Just added some preliminary comments
|
Many thanks @mmcky for the comment! I have updated the PR incorporating your comments. |
mmcky
reviewed
Jun 30, 2024
mmcky
reviewed
Jun 30, 2024
mmcky
reviewed
Jun 30, 2024
mmcky
reviewed
Jun 30, 2024
mmcky
requested changes
Jun 30, 2024
There was a problem hiding this comment.
thanks @HumphreyYang just a few more remarks and minor suggestions.
mmcky
approved these changes
Jul 3, 2024
|
@jstac this is now ready for your review. |
jstac
reviewed
Jul 4, 2024
|
Many thanks @HumphreyYang , these are much appreciated. Just very minor comments. @mmcky I'll leave you to merge when ready. |
|
thanks @jstac @HumphreyYang once this is updated -- please ping me and I will merge the PR. |
|
thanks @HumphreyYang and @jstac. Merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates additional computation and graphs for the lecture on computing square roots.