Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French Revolution Lecture #468

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Update French Revolution Lecture #468

merged 8 commits into from
Jul 10, 2024

Conversation

HumphreyYang
Copy link
Collaborator

This is a draft PR that improves French Revolution lecture.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit eee0532
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/668c9a732cb1ba0008677439
😎 Deploy Preview https://deploy-preview-468--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 26, 2024

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 02:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 02:04 Inactive
@HumphreyYang HumphreyYang marked this pull request as draft June 26, 2024 07:51
@github-actions github-actions bot temporarily deployed to pull request July 6, 2024 11:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 6, 2024 11:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 7, 2024 02:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 7, 2024 02:08 Inactive
@mmcky mmcky marked this pull request as ready for review July 8, 2024 03:09
@mmcky
Copy link
Contributor

mmcky commented Jul 8, 2024

thanks @HumphreyYang and @thomassargent30.

@thomassargent30 is happy with this PR so I will do a quick review this afternoon.

@mmcky mmcky added ready and removed in-work labels Jul 8, 2024
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 03:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 03:17 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @thomassargent30 and @HumphreyYang this is really interesting.

@HumphreyYang I have added some comments. I know Tom would like this merged soon so once they are updated we can merge and I will do a more detailed review as a follow up.

lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 02:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 02:01 Inactive
@HumphreyYang
Copy link
Collaborator Author

@HumphreyYang I have added some comments. I know Tom would like this merged soon so once they are updated we can merge and I will do a more detailed review as a follow up.

Many thanks to @mmcky for the comments. I have updated the content and made some changes to the code based on the feedback.

Thanks @thomassargent30 and @HumphreyYang, this is really interesting.

The credit for the coding and graphs in this very interesting lecture goes to @shizejin. I wish this were my work to put together so many interesting facts : )

@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 02:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 02:11 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 9, 2024

thanks @HumphreyYang

@jstac I will merge this today and we can loop around and do a more throughout review soon.

@jstac
Copy link
Contributor

jstac commented Jul 10, 2024

Sounds good @mmcky . Thanks @HumphreyYang and @shizejin !

@jstac jstac merged commit 473e58e into main Jul 10, 2024
7 checks passed
@jstac jstac deleted the french_rev branch July 10, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants