-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French Revolution Lecture #468
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thanks @HumphreyYang and @thomassargent30. @thomassargent30 is happy with this PR so I will do a quick review this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @thomassargent30 and @HumphreyYang this is really interesting.
@HumphreyYang I have added some comments. I know Tom would like this merged soon so once they are updated we can merge and I will do a more detailed review as a follow up.
Many thanks to @mmcky for the comments. I have updated the content and made some changes to the code based on the feedback.
The credit for the coding and graphs in this very interesting lecture goes to @shizejin. I wish this were my work to put together so many interesting facts : ) |
thanks @HumphreyYang @jstac I will merge this today and we can loop around and do a more throughout review soon. |
Sounds good @mmcky . Thanks @HumphreyYang and @shizejin ! |
This is a draft PR that improves French Revolution lecture.