Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add Tooze graph for Tom's edits #273

Merged
merged 7 commits into from
Jul 26, 2023
Merged

ENH: add Tooze graph for Tom's edits #273

merged 7 commits into from
Jul 26, 2023

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jul 20, 2023

This PR adds the Tooze graph to improve the long run growth lecture

  • Tom to edit and add narrative text

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit d1523ad
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/64c1728bdf13920008839c27
😎 Deploy Preview https://deploy-preview-273--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

@mmcky
Copy link
Contributor Author

mmcky commented Jul 26, 2023

@HumphreyYang would you be able to check the Tooze graph -- and fix the bounding box for plt.savefig(). The legend seems to be chopped off a little.

@HumphreyYang
Copy link
Collaborator

Many thanks @mmcky,

I also updated the code slightly so colors are distinctive in the plot.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 26, 2023

I also updated the code slightly so colors are distinctive in the plot.

Great idea. Love your work @HumphreyYang

@mmcky
Copy link
Contributor Author

mmcky commented Jul 26, 2023

@HumphreyYang what do you think about putting the legend on the right in a 2 column x 3 row layout.

Either way I think we should have a 2 x 3 or 3 x 2 (for the bottom) so the legend isn't wider than the graph. What do you think?

Screenshot 2023-07-26 at 1 29 07 pm

@HumphreyYang
Copy link
Collaborator

HumphreyYang commented Jul 26, 2023

@HumphreyYang what do you think about putting the legend on the right in a 2 column x 3 row layout.

Either way I think we should have a 2 x 3 or 3 x 2 (for the bottom) so the legend isn't wider than the graph. What do you think?

Many thanks @mmcky, I will do both and see which way looks better

@HumphreyYang
Copy link
Collaborator

Hi @mmcky,

I think the current version looks better. Please let me know if you have any suggestions : )

@thomassargent30 thomassargent30 merged commit 1e8f135 into main Jul 26, 2023
5 checks passed
@mmcky mmcky deleted the graph-work branch July 26, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants