Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in merge lecture #199

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix an issue in merge lecture #199

wants to merge 4 commits into from

Conversation

wupeifan
Copy link
Contributor

@wupeifan wupeifan commented Jan 4, 2022

This closes #198

@wupeifan wupeifan requested a review from mmcky January 4, 2022 20:43
@mmcky
Copy link
Contributor

mmcky commented Jan 5, 2022

thanks @wupeifan I will need to look into the build failure this afternoon due to sphinx_exercise?

@wupeifan
Copy link
Contributor Author

wupeifan commented Jan 5, 2022

@mmcky Yeah, I don't know what exactly happen there since I didn't touch that file in this PR and #197 . Both are failing for the same reason somehow. It shouldn't be because of the working_with_text lecture since the API of StatsCanada is now fixed.

@mmcky
Copy link
Contributor

mmcky commented Jan 5, 2022

I am actually not able to replicate the environment.yml file on my mac. It is showing loads of pip failures due to llvm. Hmm ... tricky one.

@wupeifan seems like there is an issue with

https://pypi.org/project/Fiona/

@wupeifan
Copy link
Contributor Author

wupeifan commented Jan 5, 2022

Yeah, that's possible. I think the maps lecture also uses fiona if I'm not mistaken...

@wupeifan
Copy link
Contributor Author

Just want to bump this up a bit -- is there a solution at this point?

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2022

@wupeifan I am still having issues installing fiona both locally and on github actions. I think that install issue is preventing this from building. It can't find gdal it appears. Any ideas?

@wupeifan
Copy link
Contributor Author

It seems that it's currently failing on PyPI. NO ideas... maybe try conda?

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2022

@wupeifan it has been failing for some time it appears on PyPI (last two versions).

I won't do this here but it would be good to move as many pip to conda as possible for the official environment given we are loading anaconda.

@wupeifan
Copy link
Contributor Author

I see. yeah, that makes sense.

@wupeifan
Copy link
Contributor Author

oh no it fails with the same error before.

Can I merge this one and the other PR that I have without compiling the new pages?

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2022

I'll keep plugging away at this. It needs to be fixed as the new "publish" build wouldn't complete to publish the updates.

Also documented the issue: executablebooks/sphinx-exercise#46

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2022

@wupeifan looks like there is just one build issue with

  • working_with_text

building locally now to get a copy of the logs

LookupError: 
**********************************************************************
  Resource �[93momw-1.4�[0m not found.
  Please use the NLTK Downloader to obtain the resource:

  �[31m>>> import nltk
  >>> nltk.download('omw-1.4')
  �[0m
  For more information see: https://www.nltk.org/data.html

  Attempted to load �[93mcorpora/omw-1.4�[0m

  Searched in:
    - '/home/runner/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/share/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/lib/nltk_data'
    - '/usr/share/nltk_data'
    - '/usr/local/share/nltk_data'
    - '/usr/lib/nltk_data'
    - '/usr/local/lib/nltk_data'
**********************************************************************

not sure why this isn't loading as omw-1.4 is listed if you click through to the nltk listing.

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2022

@wupeifan I have run out of time today. The environment.yml for this project is really fragile. I get a lot of local errors when trying to build it on os x. The failure report still indicates there is an issue with nltk

https://github.com/QuantEcon/lecture-datascience.myst/suites/4919403137/artifacts/141871880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report on the pandas merge lecture
2 participants