Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer Polymatrix Game Solver (new for QuantEcon) #741

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GautamsGitHub
Copy link

Multiplayer Polymatrix Game Solver

The Linear Complementary Problem solving step requires some modifications from the one available in QuantEcon's LCP Lemke. I have added this solver. It is based on Howson's paper . The only other implementation I have seen of it is in C in GameTracer.

Polymatrix Games
I have added a class for dealing with polymatrix games. This was part of a larger project of mine with many utility functions on games and my own class for normal form games but I have trimmed most of this away from contribution to QuantEcon.

gam files
Gametracer's gam files are a good way of storing games in files because they can be generated by GAMUT. I add a function to load a QuantEcon game from a gam file.

@pep8speaks
Copy link

pep8speaks commented Nov 5, 2024

Hello @GautamsGitHub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-05 15:46:57 UTC

@GautamsGitHub GautamsGitHub reopened this Nov 5, 2024
@GautamsGitHub GautamsGitHub changed the title Multiplayer Polymatrix Game Solver (new to QuantEcon) Multiplayer Polymatrix Game Solver (new for QuantEcon) Nov 5, 2024
@oyamad
Copy link
Member

oyamad commented Nov 6, 2024

@GautamsGitHub Thank you so much for your contribution! Let me play around with it and then I will comment.

@oyamad oyamad self-assigned this Nov 6, 2024
Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick comment: Could you modify the docstrings in accordance with this page?

For example, Args: -> Parameters with ----------.

Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the errors in the tests, you may cherry-pick this 82e4eba; and also this 61d102b.

@GautamsGitHub
Copy link
Author

I didn't realise how the pytest system would work. My tests use some relative file paths so don't work from the base directory. I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants