-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplayer Polymatrix Game Solver (new for QuantEcon) #741
base: main
Are you sure you want to change the base?
Conversation
Hello @GautamsGitHub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-05 15:46:57 UTC |
@GautamsGitHub Thank you so much for your contribution! Let me play around with it and then I will comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick comment: Could you modify the docstrings in accordance with this page?
For example, Args:
-> Parameters
with ----------
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realise how the pytest system would work. My tests use some relative file paths so don't work from the base directory. I will fix this. |
Multiplayer Polymatrix Game Solver
The Linear Complementary Problem solving step requires some modifications from the one available in QuantEcon's LCP Lemke. I have added this solver. It is based on Howson's paper . The only other implementation I have seen of it is in C in GameTracer.
Polymatrix Games
I have added a class for dealing with polymatrix games. This was part of a larger project of mine with many utility functions on games and my own class for normal form games but I have trimmed most of this away from contribution to QuantEcon.
gam files
Gametracer's gam files are a good way of storing games in files because they can be generated by GAMUT. I add a function to load a QuantEcon game from a gam file.