Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: loadExistingHoldings in SetJob use like config #120

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Jul 31, 2024

Description

  1. Configuration Update: The loadExistingHoldings configuration in the factory brokerage class is now properly utilized. Previously, this configuration was not correctly applied and was being handled through the factory's BrokerageData dictionary. This update ensures that loadExistingHoldings is initialized correctly by using the configuration settings directly.
  2. Project Removal: The ToolBox project has been removed from the solution. We now use the generic DataDownload class from Lean, making the ToolBox project redundant.

Related Issue

N/A

Related PRs

Motivation and Context

Configuration Update: The current implementation did not utilize the loadExistingHoldings configuration, leading to potential inconsistencies and manual handling through the brokerageData dictionary. By making this change, we align the loadExistingHoldings initialization with the intended configuration settings, improving code maintainability and clarity.
Project Removal: Removing the ToolBox project simplifies the solution structure and reduces maintenance overhead since the generic DataDownload class from Lean fulfills our requirements.

Requires Documentation Change

N/A

How Has This Been Tested?

  • Updated the SetJob method to fetch loadExistingHoldings from the configuration.
  • Added a specific internal property in modules.json.
  • Tested thoroughly through lean-cli and explicit testing of the lean DLL
  • Verified that all functionalities previously handled by the ToolBox project are now covered by the generic DataDownload class from Lean.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes self-assigned this Jul 31, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 5cf6e91 into master Aug 2, 2024
1 check failed
@Martin-Molinero Martin-Molinero deleted the refactor-load-existing-holdings-parameter branch August 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants