Refactor: loadExistingHoldings
in SetJob
use like config
#120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loadExistingHoldings
configuration in the factory brokerage class is now properly utilized. Previously, this configuration was not correctly applied and was being handled through the factory'sBrokerageData
dictionary. This update ensures thatloadExistingHoldings
is initialized correctly by using the configuration settings directly.ToolBox
project has been removed from the solution. We now use the genericDataDownload
class from Lean, making theToolBox
project redundant.Related Issue
N/A
Related PRs
Motivation and Context
Configuration Update: The current implementation did not utilize the
loadExistingHoldings
configuration, leading to potential inconsistencies and manual handling through thebrokerageData
dictionary. By making this change, we align theloadExistingHoldings
initialization with the intended configuration settings, improving code maintainability and clarity.Project Removal: Removing the
ToolBox
project simplifies the solution structure and reduces maintenance overhead since the genericDataDownload
class from Lean fulfills our requirements.Requires Documentation Change
N/A
How Has This Been Tested?
SetJob
method to fetchloadExistingHoldings
from the configuration.modules.json
.DataDownload
class from Lean.Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>