Made MPI calls in exchangeStateVectors non-blocking #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
exchangeStateVectors
was modified to take advantage of non-blocking MPI communication.Currently, QuEST uses blocking communication calls to exchange the statevector in chunks of 2GB. On large systems, which feature high memory and a fast interconnect, this caused a noticeable slowdown. By changing the communication to non-blocking, up to 10% speedup was achieved on ARCHER2, as described in the following paper: https://arxiv.org/abs/2308.07402.
Ideally the request array would not be allocated and freed in this function, however, placing it elsewhere would require introducing MPI headers in areas of the code in which they are not currently required, for example in QuESTEnv.