v3.6.0 #363
Merged
v3.6.0 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows derivative projects like QuESTlink which hook into the backend utilities, to invoke this function. This function is needed to pre-prepare a Kraus superoperator before QuEST simulation.
This enables them to be compiled and run natively on Windows. Serial and multithreading are now working (woo!) but sadly GPU seg-faults when run after a seemingly successful compilation.
tested on: - serial, multithreaded (on Clang and MSVC) - GPU-build on Clang - GPU unit test (GCC) - distributed up to 16 nodes (wrapping GCC)
for distributed testing.
In some unit tests, the number of ranks (int) was set to a value exceeding INT_MAX. This commit caps the number of qubits the tests are run with to a number (16 or 32) that avoids this.
and accompanying functions: - createSubDiagonalOp() - destroySubDiagonalOp() - diagonalUnitary() - applySubDiagonalOp() - applyGateSubDiagonalOp() A SubDiagonalOp is a non-distributed structure which effects a diagonal unitary (specified only through the diagonal elements) upon any subset of a qureg's qubits.
* added header file with macros for cuda -> hip translation * Updated CMakeLists.txt to support GPU compilation with HIP * added brief instructions to build with HIP after the instructions to compile with GPU support.
tested with 1, 16 threads, GPU, 1-2 nodes
in addition to the existing CI build test. This patch involved accelerating some tests to avoid timeouts, and replicating (in a Catch2 v2 compatible way) the Catch2 patch for this Windows-specific issue: catchorg/Catch2#2040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This release makes QuEST compatible with AMD GPUs 🎉, makes the unit tests compatible with MSVC on Windows, and adds sub-diagonal operators.
New features
SubDiagonalOp; a non-distributed structure representing a diagonal unitary (specified only through the diagonal elements) upon a subset of a qureg's qubits. This can be passed to new functions:createSubDiagonalOp()destroySubDiagonalOp()diagonalUnitary()applySubDiagonalOp()applyGateSubDiagonalOp()applyGateMatrixN()applyMultiControlledGateMatrixN()setQuregToPauliHamil()for casting a Pauli Hamiltonian into a dense Z-basis matrix, stored in a density matrixQureg.SCALED_INVERSE_SHIFTED_WEIGHTED_DISTANCErecognised byapplyParamNamedPhaseFunc()(and related functions)Other changes
Bug fixes
cos()) now explicitly use quad precision when compiled withPRECISION=4, thanks to @Milos9304