Add chatAuthBypassEnabled setting #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
chatAuthBypassEnabledsetting that can be used by any public nodes, or others who want to allow CHAT transactions to be processed by their node, without requiring an API key check. The setting is set tofalseby default, as there was previously some discussion about removing this API key requirement entirely, and the decision was made to not do so. This appears to be a reasonable compromise, and would effectively change nothing at all for most users, unless they manually chose to apply this new setting. Allowing this option will give other applications, such as SYNQ, a way to provide more functionality for those who are not able to access their own private node at all times, but still would like to interact with the Qortal community while they are travelling, away from home, etc. If this change is not acceptable or there are any other issues, considerations, or questions, please let me know. This could be a good step towards creating a more versatile mobile Qortal application that gains wide usage, and helps to expand the community.