Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nodeId #168

Closed
wants to merge 1 commit into from
Closed

Conversation

QuickMythril
Copy link

No description provided.

@crowetic
Copy link

crowetic commented Mar 6, 2024

What is the reason to remove the nodeID? I thought that in the future we might utilize nodeID in order to be able to 'count' the number of nodes on the network. Just wondering your thought process here.

@QuickMythril
Copy link
Author

This pull request was created based on a misunderstanding of what the nodeId is used for and how the peer handshake messaging works. It may be worth discussing in the future, but it does not seem to be a good use of development resources at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants