Modify difficulty adjustment #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
frankcrypto2023
commented
Nov 29, 2023
frankcrypto2023
commented
- Use blocks generated by all DAGs as the basis for difficulty adjustment
dindinw
reviewed
Nov 30, 2023
common/util/math/min_test.go
Outdated
| package math_test | ||
|
|
||
| import ( | ||
| utilMath "github.com/kaspanet/kaspad/util/math" |
There was a problem hiding this comment.
we don't have to add the extra dependence.
lochjin
reviewed
Nov 30, 2023
core/blockchain/difficulty.go
Outdated
| break | ||
| } | ||
|
|
||
| for id := range oldBlock.GetParents().GetMap() { |
There was a problem hiding this comment.
The getBlockWindows result of each run may be different because the selection of blocks is not detailed and specific enough
frankcrypto2023
force-pushed
the
dev/1.2-diff
branch
from
49b08dc to
248ddd6
Compare
lochjin
approved these changes
Dec 11, 2023
dindinw
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.