Optimize block about assert immutability

core/blockchain/process.go

@@ -243,7 +243,11 @@ func (b *BlockChain) maybeAcceptBlock(block *types.SerializedBlock, flags Behavi
 	//
 	// Also, store the associated block index entry.
 	if !b.DB().HasBlock(block.Hash()) {
-		err := dbMaybeStoreBlock(b.DB(), block)
+		err := block.AssertImmutability()
+		if err != nil {
+			return nil, err
+		}
+		err = dbMaybeStoreBlock(b.DB(), block)
 		if err != nil {
 			panic(err.Error())
 		}

core/types/block.go

@@ -459,10 +459,17 @@ func NewBlockDeepCopyCoinbase(msgBlock *Block) *SerializedBlock {
 // calling BlockHash on the underlying Block, however it caches the
 // result so subsequent calls are more efficient.
 func (sb *SerializedBlock) Hash() *hash.Hash {
-	//TODO, might need to assertBlockImmutability
 	return &sb.hash
 }
 
+func (sb *SerializedBlock) AssertImmutability() error {
+	h := sb.block.BlockHash()
+	if (&h).IsEqual(&sb.hash) {
+		return nil
+	}
+	return fmt.Errorf("block hash inconsistent:%s != %s", h.String(), sb.hash.String())
+}
+
 func (sb *SerializedBlock) Block() *Block {
 	return sb.block
 }