ASV time_param_circSU2_100_build no longer needs to call _build.
#13781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the ASV test bench, a circuit construction test, `time_param_circSU2_100_build` which used to be implemented on top of a `BlueprintCircuit` no longer needs to call `_build`.
|
One or more of the following people are relevant to this code:
|
mtreinish
approved these changes
Feb 3, 2025
Pull Request Test Coverage Report for Build 13116720666Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following commits remove an invalid function call that would make
circuit_constructiontests fail on ASV.Details and comments
In the ASV test bench, a circuit construction test,
time_param_circSU2_100_buildwhich used to be implemented on top of aBlueprintCircuitno longer needs to call_build. The following commits remove this function call.