-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CommutationChecker
for 2q Pauli rotations
#13762
base: main
Are you sure you want to change the base?
Conversation
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13115566069Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a small comment in the test.
Summary
Fixes #13742.
Details and comments
Fix a bug
CommutationChecker
for[2q Pauli rotations, a gate that is not in the cache]
, such as[RXX, U]
. The issue was that the parameters of the Pauli rotations were set to[]
because we assumed we can find the relation in the cache. However that's obviously not true, as there are gates that are neither rotations, nor in the cache.