Oxidize UnitarySynthesis path using basis_gates
#13704
Draft
+343
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
changed the title
UnitarySynthesis path using basis_gates, remove use of BackendV1 in testsUnitarySynthesis path using basis_gates
Pull Request Test Coverage Report for Build 12905680507Details
💛 - Coveralls |
| } | ||
|
|
||
| // Used in get_2q_decomposers. If the found 2q basis is a subset of GOODBYE_SET, | ||
| // then we know TwoQubitBasisDecomposer is an ideal decomposition and there is | ||
| // no need to bother trying the XXDecomposer. | ||
| static GOODBYE_SET: [&str; 3] = ["cx", "cz", "ecr"]; | ||
|
|
||
| fn get_euler_basis_set(basis_list: IndexSet<&str>) -> EulerBasisSet { |
There was a problem hiding this comment.
A small question about the type of basis_list: why does it need to be a set (and not say a vec) and why does it need to be index (the order is not important here, right?)
| )?; | ||
| let out_qargs = dag.get_qargs(packed_instr.qubits); | ||
| apply_synth_dag(py, &mut out_dag, out_qargs, &synth_dag)?; | ||
| if basis_gates.is_empty() && matches!(target, None) { |
There was a problem hiding this comment.
Minor question: is there a benefit of writing matched!(target, None) over target.is_none()?
| Some(params.iter().map(|p| Param::Float(*p)).collect()), | ||
| inst_qubits, | ||
| ), | ||
| } | ||
| }); | ||
| let synth_error_from_target = synth_error(py, scoring_info, target); | ||
| let synth_error_from_target = synth_error(py, scoring_info, target.unwrap()); |
There was a problem hiding this comment.
Why target can't be None here?
Comment on lines
-353
to
-354
| backend_props (BackendProperties): Properties of a backend to | ||
| synthesize for (e.g. gate fidelities). |
There was a problem hiding this comment.
Ah, I see, the BackendProperties should be removed by the "prequel" PR #13706, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a compilation of small improvements to the
UnitarySynthesispass, including:Performance -> Addition of fast path (Rust) for the use case where
target is None, all input combinations can now be run using the fast path.Fixes -> Fixed an oversight where the
pulse_optimizeargument wasn't added to the fast path and therefore ignored (discovered after expanding the unit tests).These set the stage for future refactorings of the
UnitarySynthesisclass to take better advantage of the plugin model (the default plugin is currently ignored in the fast path).Note that this PR touches on code that is currently actively worked on in:
UnitarySynthesistranspiler pass #13568And builds on top of #13706 (will need to be rebased after it's merged).
Details and comments