Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some Qiskit Terra links to Qiskit repo #705

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Update some Qiskit Terra links to Qiskit repo #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions qiskit_addon_cutting/qpd/decompositions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def qpdbasis_from_instruction(gate: Instruction, /) -> QPDBasis:
All two-qubit gates which implement the :meth:`~qiskit.circuit.Gate.to_matrix` method are
supported. This should include the vast majority of gates with no unbound
parameters, but there are some special cases (see, e.g., `qiskit issue #10396
<https://github.com/Qiskit/qiskit-terra/issues/10396>`__).
<https://github.com/Qiskit/qiskit/issues/10396>`__).

The :class:`.Move` operation, which can be used to specify a wire cut,
is also supported.
Expand Down Expand Up @@ -323,7 +323,7 @@ def _(unused_gate: iSwapGate):
def _(unused_gate: DCXGate):
retval = qpdbasis_from_instruction(iSwapGate())
# Modify basis according to DCXGate definition in Qiskit circuit library
# https://github.com/Qiskit/qiskit-terra/blob/e9f8b7c50968501e019d0cb426676ac606eb5a10/qiskit/circuit/library/standard_gates/equivalence_library.py#L938-L944
# https://github.com/Qiskit/qiskit/blob/e9f8b7c50968501e019d0cb426676ac606eb5a10/qiskit/circuit/library/standard_gates/equivalence_library.py#L938-L944
for operations in unique_by_id(m[0] for m in retval.maps):
operations.insert(0, SdgGate())
operations.insert(0, HGate())
Expand Down Expand Up @@ -486,7 +486,7 @@ def _(gate: CXGate | CYGate | CZGate | CHGate):
def _(unused_gate: ECRGate):
retval = qpdbasis_from_instruction(CXGate())
# Modify basis according to ECRGate definition in Qiskit circuit library
# https://github.com/Qiskit/qiskit-terra/blob/d9763523d45a747fd882a7e79cc44c02b5058916/qiskit/circuit/library/standard_gates/equivalence_library.py#L656-L663
# https://github.com/Qiskit/qiskit/blob/d9763523d45a747fd882a7e79cc44c02b5058916/qiskit/circuit/library/standard_gates/equivalence_library.py#L656-L663
for operations in unique_by_id(m[0] for m in retval.maps):
operations.insert(0, SGate())
operations.append(XGate())
Expand Down
4 changes: 2 additions & 2 deletions qiskit_addon_cutting/utils/observable_grouping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def most_general_observable(
# it _could_ be, *especially* if given a PauliList.
#
# Indeed, this can be made better by using pauli.x and pauli.z arrays
# https://github.com/Qiskit/qiskit-terra/blob/061aee2685676271fd0860d0a2d699e36941ae5e/qiskit/primitives/backend_estimator.py#L403-L404
# https://github.com/Qiskit/qiskit/blob/061aee2685676271fd0860d0a2d699e36941ae5e/qiskit/primitives/backend_estimator.py#L403-L404
for j, obs in enumerate(commuting_observables):
if not isinstance(obs, Pauli):
raise ValueError("Input sequence includes something other than a Pauli.")
Expand Down Expand Up @@ -135,7 +135,7 @@ class CommutingObservableGroup:

def __post_init__(self) -> None:
"""Post-init method for the data class."""
# TODO(perf): These loops could be faster; see e.g. https://github.com/Qiskit/qiskit-terra/blob/061aee2685676271fd0860d0a2d699e36941ae5e/qiskit/primitives/backend_estimator.py#L398-L413
# TODO(perf): These loops could be faster; see e.g. https://github.com/Qiskit/qiskit/blob/061aee2685676271fd0860d0a2d699e36941ae5e/qiskit/primitives/backend_estimator.py#L398-L413
pauli_indices: list[int] = [
i for i, pauli in enumerate(self.general_observable) if pauli != _I
]
Expand Down
2 changes: 1 addition & 1 deletion test/qpd/test_qpd_basis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def test_unbound_parameter(self):
with self.subTest("Implicitly supported gate"):
# For implicitly supported gates, we can detect that `to_matrix`
# failed, but there are other possible explanations, too. See
# https://github.com/Qiskit/qiskit-terra/issues/10396
# https://github.com/Qiskit/qiskit/issues/10396
with pytest.raises(ValueError) as e_info:
QPDBasis.from_instruction(XXPlusYYGate(Parameter("θ")))
assert (
Expand Down