Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for Python 3.13 #648

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Add explicit support for Python 3.13 #648

merged 9 commits into from
Nov 5, 2024

Conversation

garrison
Copy link
Member

The first release candidate of Python 3.13 is due to be released in a few days, with the final release scheduled for Oct 1. This adds CI testing against and explicit support for Python 3.13.

@coveralls
Copy link

coveralls commented Jul 27, 2024

Pull Request Test Coverage Report for Build 10154644994

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10154171115: 0.0%
Covered Lines: 2410
Relevant Lines: 2410

💛 - Coveralls

@garrison garrison added the on hold Let's wait for something before merging label Jul 27, 2024
@garrison
Copy link
Member Author

garrison commented Jul 28, 2024

From the CI failure, it looks like we are waiting on scipy wheels for Python 3.13. They exist but have not yet been uploaded to pypi.

garrison added a commit that referenced this pull request Jul 30, 2024
This started off as part of #648, but it is conceptually an
independent change, so I am splitting it off into its own
commit.
garrison added a commit that referenced this pull request Jul 30, 2024
This started off as part of #648, but it is conceptually an
independent change, so I am splitting it off into its own
commit.
@garrison
Copy link
Member Author

From the CI failure, it looks like we are waiting on scipy wheels for Python 3.13. They exist but have not yet been uploaded to pypi.

Wheels have been uploaded to pypi. I will kick off CI again.

@garrison
Copy link
Member Author

garrison commented Aug 21, 2024

Waiting now on symengine wheels: https://pypi.org/project/symengine/#files and symengine/symengine-wheels#17

@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11240162985

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10889446481: 0.0%
Covered Lines: 2408
Relevant Lines: 2408

💛 - Coveralls

@garrison
Copy link
Member Author

garrison commented Oct 1, 2024

CI passed on 3.13-dev thanks to the symengine release today which included python 3.13 wheels. This indicates that we should be able to merge this as soon as the setup-python action catches up to the Python 3.13 release tomorrow.

@garrison garrison removed the on hold Let's wait for something before merging label Oct 8, 2024
@garrison garrison marked this pull request as ready for review October 8, 2024 16:49
@garrison
Copy link
Member Author

garrison commented Oct 8, 2024

Windows support is waiting on a python 3.13 wheel for Qiskit Aer, but we are already able to support Python 3.13 on macOS and Linux.

@garrison garrison added the stable backport potential Suitable to be backported to most recent stable branch by Mergify label Nov 5, 2024
@garrison garrison merged commit 7757854 into main Nov 5, 2024
11 checks passed
@garrison garrison deleted the py313 branch November 5, 2024 09:45
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
* Add explicit support for Python 3.13

* Ask setup-python to install a dev version of Python 3.13

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-the-python-version-input

* Fix CI scripts to work with prerelease versions of Python

* Longer variable name

* Update test_latest_versions.yml

Remove `-dev`

* Test on 3.13 across all operating systems

* Revert win32 py313

(cherry picked from commit 7757854)
garrison added a commit that referenced this pull request Nov 5, 2024
* Add explicit support for Python 3.13

* Ask setup-python to install a dev version of Python 3.13

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#using-the-python-version-input

* Fix CI scripts to work with prerelease versions of Python

* Longer variable name

* Update test_latest_versions.yml

Remove `-dev`

* Test on 3.13 across all operating systems

* Revert win32 py313

(cherry picked from commit 7757854)

Co-authored-by: Jim Garrison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants