Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cutQC #605

Merged
merged 15 commits into from
May 24, 2024
Merged

Remove cutQC #605

merged 15 commits into from
May 24, 2024

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented May 22, 2024 •
edited
Loading

Fixes #519

Remaining action items

  • Release note
  • Remove utils/conversion.py and utils/metrics.py
  • Remove --omit="circuit_knitting/cutting/cutqc/**/*,circuit_knitting/utils/conversion.py,circuit_knitting/utils/metrics.py" from coverage command in tox.ini
  • Remove cutqc and metrics from addopts line in pyproject.toml, and anything else added temporarily as part of Deprecate CutQC #527
  • grep for remaining references to cplex (e.g. in the README)

@coveralls
Copy link

coveralls commented May 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9225128307

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.5%) to 100.0%
Totals Coverage Status
Change from base Build 9184284091: 4.5%
Covered Lines: 2375
Relevant Lines: 2375
💛 - Coveralls

@garrison garrison added this to the 0.8.0 milestone May 22, 2024
@caleb-johnson
Copy link
Collaborator Author

caleb-johnson commented May 22, 2024 •
edited
Loading

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI due to references to missing package

@garrison
Copy link
Member

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI

It's because we don't use Sphinx's "nitpicky" mode, so classes that don't exist don't raise errors. I tried experimenting with this mode in #196 but it was a disaster.

@garrison
Copy link
Member

OK, maybe my idea to use Docker on macOS was half baked ;) since Docker is apparently not installed on the macOS image that github actions uses.

We can always make this change in a future PR if we really want to test Docker on M series Mac.

@caleb-johnson caleb-johnson changed the title Remove cutQC first pass Remove cutQC May 22, 2024
ibrahim-shehzad
ibrahim-shehzad previously approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ibrahim-shehzad ibrahim-shehzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for taking care of this.

garrison
garrison reviewed May 22, 2024
View reviewed changes
CITATION.bib Outdated Show resolved Hide resolved
garrison
garrison reviewed May 23, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
garrison
garrison reviewed May 23, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@garrison
Copy link
Member

  • Overall coverage increased (+4.5%) to 100.0%

We should throw a party 🎉 🚀

garrison
garrison reviewed May 23, 2024
View reviewed changes
INSTALL.rst Outdated Show resolved Hide resolved
@caleb-johnson @garrison
Update INSTALL.rst
7b6fdfa 
Co-authored-by: Jim Garrison <[email protected]>
@caleb-johnson @garrison
Update pyproject.toml
9f084f9 
Co-authored-by: Jim Garrison <[email protected]>
garrison
garrison reviewed May 24, 2024
View reviewed changes
INSTALL.rst Show resolved Hide resolved
garrison
garrison previously approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy with this. Thank you for taking the lead on this. There is only my single last-minute comment remaining, about the last point in INSTALL.rst.

Coverage to 100% 🚀

@caleb-johnson caleb-johnson merged commit 608f9ec into main May 24, 2024
13 checks passed
@caleb-johnson caleb-johnson deleted the remove-cutqc branch May 24, 2024 14:52
garrison added a commit that referenced this pull request Jul 8, 2024
@garrison
Pin numpy<2 on stable branch
1a1499f 
From the looks of the CI failure, DOCplex is incompatible with numpy 2.0.  So, as a way to make the CutQC code continue to work, I am pinning to `numpy <2` on the `stable/0.7` branch.  (CutQC has already been removed from `main`, in #605.)
@garrison garrison mentioned this pull request Jul 8, 2024
Merged
garrison added a commit that referenced this pull request Jul 8, 2024
@garrison
Pin numpy<2 on stable branch (#631)
ee6cf5b 
From the looks of the CI failure, DOCplex is incompatible with numpy 2.0.  So, as a way to make the CutQC code continue to work, I am pinning to `numpy <2` on the `stable/0.7` branch.  (CutQC has already been removed from `main`, in #605.)
garrison added a commit that referenced this pull request Aug 21, 2024
@caleb-johnson @garrison
Remove cutQC (#605)
dab3f3a 
---------

Co-authored-by: Jim Garrison <[email protected]>
garrison added a commit that referenced this pull request Aug 21, 2024
@garrison @caleb-johnson
Backport CutQC removal to stable/0.8 branch (#662)
6cdb82d 
* Revert "Pin qiskit-ibm-runtime when running notebooks (#659)"

This reverts commit 9684220.

* Revert "Pin numpy<2 on stable branch (#631)"

This reverts commit ee6cf5b.

* Revert "Switch to `macos-13` runner so it is an Intel chip (#561)"

This reverts commit 69adfc5.

* Remove cutQC (#605)

---------

Co-authored-by: Jim Garrison <[email protected]>

---------

Co-authored-by: Caleb Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrison garrison garrison approved these changes

@ibrahim-shehzad ibrahim-shehzad ibrahim-shehzad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Remove CutQC
4 participants
@caleb-johnson @coveralls @garrison @ibrahim-shehzad