enforce 50 <= description length <= 160 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsung
force-pushed
the
kjs/metadata-length
branch
from
463e9a4
to
4f01fc6
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the the following people are requested to review this:
|
|
👍 for docs/run/quantum-serverless.mdx |
Eric-Arellano
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Thanks! We'll want to make an exception for API docs but this can be fixed in my follow up work to start running the metadata checker on API docs.
The new descriptions look solid to me. Maybe wait for sign off from @javabster because she did the first pass at rewriting these descriptions last time.
javabster
reviewed
Feb 26, 2024
Eric-Arellano
approved these changes
Feb 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Follow up to #890. API docs are auto-generated so we can't easily fix if the line length is not ideal, which often happens from being too short.
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Follow up to Qiskit#890. API docs are auto-generated so we can't easily fix if the line length is not ideal, which often happens from being too short.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327