remove matplotlib figure captions #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Huzzah! After making the requested changes, you'll need to run npm run regen-apis. This takes ~40 minutes and means you can't make changes to the repo because it messes up your Git state, so I recommend doing it during meetings. It runs in the background. Or let me know if you want me to run it for you.
|
@Eric-Arellano I've run |
|
Apparently that introduced some broken links. Do you know how to fix it? |
|
Oops, I introduced them in #850. Our link checker didn't run like it should have. I'll fix. |
This was referenced Feb 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
The API checks didn't run in #850 because our GitHub Action didn't include `public/api` in its globs. So, we accidentally broke the link checker. This PR adds the new mechanism of `IGNORED_FILES`. The `objects.inv` has way too many errors in 0.14 - 0.16 to be worth trying to fix or blocklist specific failures. Finally, it removes ignores that are now stale thanks to #848.
Eric-Arellano
added a commit
that referenced
this pull request
Feb 21, 2024
Follow up to #848. Sphinx used to use a different HTML structure we weren't accounting for. After this PR, there are no more bad URLs: ``` ❯ rg '_downloads' -l scripts/lib/api/htmlToMd.test.ts scripts/lib/links/ignores.ts scripts/lib/api/processHtml.test.ts ```
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
The API checks didn't run in Qiskit#850 because our GitHub Action didn't include `public/api` in its globs. So, we accidentally broke the link checker. This PR adds the new mechanism of `IGNORED_FILES`. The `objects.inv` has way too many errors in 0.14 - 0.16 to be worth trying to fix or blocklist specific failures. Finally, it removes ignores that are now stale thanks to Qiskit#848.
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Follow up to Qiskit#848. Sphinx used to use a different HTML structure we weren't accounting for. After this PR, there are no more bad URLs: ``` ❯ rg '_downloads' -l scripts/lib/api/htmlToMd.test.ts scripts/lib/links/ignores.ts scripts/lib/api/processHtml.test.ts ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #732