Better organize link checker ignores #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucasau
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Good idea with this change!! One question, isn't it dangerous to ignore relative links and anchors (e.g., #id1)? We could have a file with the same name in different APIs that will be ignored unintentionally. I don't think this will happen in the API docs, but maybe with some anchors and section titles. What do you think?
I think it depends on the anchor. Certain highly generic ones like |
arnaucasau
approved these changes
Feb 19, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
This adds the idea of "always ignored URLs", rather than making us repeat every file in which the URL appears. That has become necessary now that we have dev and historical API docs. This PR also removes some stale ignores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the idea of "always ignored URLs", rather than making us repeat every file in which the URL appears. That has become necessary now that we have dev and historical API docs.
This PR also removes some stale ignores.