-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation on transpiler plugins #781
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick read over the content it looks good. Just a few inline comments/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, thanks! I followed this successfully and I understand how I'd modify the examples with my own custom code.
I just have a couple of suggestions to smooth over the user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty great! I just wanted to include more specific examples in cases mostly, somewhat in anticipation of how users will consume this.
@nbronn please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice intro! Very clear and celebrates the open-source community 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We edit the
pyproject.toml
,setup.cfg
, orsetup.py
file of our package
I'm a bit confused about this section. How does a user know which file they should update? Does it depend on what type of plugin they're developing? Whatever the reason I think it would be good to highlight how a user decides which to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, your own plugin will do something more interesting than that.
Lol such sass I love it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create our UnitarySynthesisPlugin subclass
For the code snippet following this line can you add some code comments briefly explaining each property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a "next steps" section to the end of the file? every docs page should have a next steps that includes at least one link to the learning platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do you think we should split these 3 examples up into separate pages? The page feels quite long and I wonder if it would be more digestible if split up 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this section. How does a user know which file they should update? Does it depend on what type of plugin they're developing? Whatever the reason I think it would be good to highlight how a user decides which to update
pyproject.toml
, setup.cfg
, or setup.py
are three different formats for storing the metadata for a Python project. Typically the creator of the package chooses only one of these formats, so there wouldn't be any confusion as to which file to edit (because only one of them exists). I've added a parentheses nothing this fact.
For the code snippet following this line can you add some code comments briefly explaining each property?
Done.
Could you please add a "next steps" section to the end of the file? every docs page should have a next steps that includes at least one link to the learning platform
Do you actually mean learning platform, or just the IQP platform in general (including documentation)? In any case, I couldn't think of an appropriate next step on these platforms, but I did add a next step for contributing the plugin to the Qiskit Ecosystem. Do you have any other specific pages in mind?
question: do you think we should split these 3 examples up into separate pages? The page feels quite long and I wonder if it would be more digestible if split up 🤔
I actually think it's better to have them all on one page. The right sidebar has the table of contents which makes the page easier to navigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you actually mean learning platform,
Yes I actually mean learning platform. In general we need to be more closely linking these 2 platforms so one of our goals is to have every docs page link to learning and vice versa. There might not be a specific page that fits perfectly for this but anything you think generally might be useful and focused around the theme of transpiling is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added generic links to the learning platform tutorials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #102 .