-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metapackage migration guide #2611
Conversation
One or more of the following people are relevant to this code: |
@@ -14,7 +14,11 @@ | |||
"url": "/migration-guides/qiskit-1.0" | |||
}, | |||
{ | |||
"title": "Packaging changes", | |||
"title": "Understand the breaking package changes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be "package" or "packaging"? The metapackage-migration file uses "packaging".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up deciding to change everything to "package"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Co-authored-by: abbycross <[email protected]>
Closes #2487 and is the last issue for and closes #2146