Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate SQD feedback #2460

Merged
merged 6 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/guides/qiskit-addons-sqd-get-started.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1824,9 +1824,11 @@
"source": [
"Now, run the configuration recovery loop. Each loop consists of three steps:\n",
"\n",
"1. Use the `recover_configurations()` method to obtain a refined bitstring matrix and probability array based on the average orbital occupancy.\n",
"1. Use the `recover_configurations()` function to obtain a refined bitstring matrix and probability array based on the average orbital occupancy.\n",
"1. Use the `postselect_and_subsample()` to collect batches of subsamples to diagonalize over.\n",
"1. Then use the batches of subsamples as arguments to the `solve_fermion()` method to obtain an approximation of the ground state."
"1. Then use the batches of subsamples as arguments to the `solve_fermion()` function to obtain an approximation of the ground state.\n",
"\n",
"It is important to note how to address the first iteration of the configuration recovery loop. Since the average orbital occupancy is not yet available, only the `postselect_and_subsample()` function is called. This removes any non-physical samples (samples with incorrect Hamming weight) before running the eigenstate solver, `solve_fermion()`. Afterward, the average orbital occupation is calculated across all batches and used as input to the `recover_configurations()` method, which flips individual bits probabilistically based on this average. See Section **II-A** of the supplementary information in the [SQD paper](https://arxiv.org/abs/2405.05068) for more information."
]
},
{
Expand Down Expand Up @@ -1975,6 +1977,8 @@
"# Data for energies plot\n",
"n2_exact = -109.10288938\n",
"x1 = range(ITERATIONS)\n",
"# Here we plot the smallest energy obtained across all batches for each iteration\n",
"# of the configuration recovery loop.\n",
"e_diff = [abs(np.min(energies) - n2_exact) for energies in energy_hist]\n",
"yt1 = [1.0, 1e-1, 1e-2, 1e-3, 1e-4]\n",
"\n",
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/qiskit-addons-sqd.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ $$ \hat{H}_{S^{(k)}} = \hat{P}_{\mathcal{S}^{(k)}}\hat{H}\hat{P}_{\mathcal{S}^{(

where $\hat{H}_{\mathcal{S}^{(k)}}$ is the Hamiltonian of a given subspace.

The bulk of the SQD workflow lies here wherein each of these subspace Hamiltonians is diagonalized. The ground states obtained from each of these subspaces, $|\psi^{(k)}\rangle$, are used to obtain an estimate of a reference vector of occupancies $\mathbf{n}^{(K)}$ averaged over each of the $K$ subspaces and sent back to the configuration recovery step. A new set of subspaces are then obtained and diagonalized, and this procedure iterates in a loop until a user specified criterion is met.
The bulk of the SQD workflow lies here wherein each of these subspace Hamiltonians is diagonalized. The ground states obtained from each of these subspaces, $|\psi^{(k)}\rangle$, are used to obtain an estimate of a reference vector of occupancies $\mathbf{n}^{(K)}$ averaged over each of the $K$ subspaces. A new set of configurations $\mathcal{X}_R$ is then generated by probabilistically flipping individual bits based on this average occupation and the known total number of particles (Hamming weight) in the system. This configuration recovery process is then repeated by preparing a new set of subspaces to diagonalize, obtaining new eigenstates and averaged orbital occupancy, and generating a new set of configurations. This loop is iterated until a user-specified criterion is met, and the overall process is analogous to filtering a noisy signal to improve its fidelity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the two "obtain"s in the second sentence 😆 but I don't know that it's worth wordsmithing since it makes sense, so I'll leave it for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Just changed the wording around a bit



## Next steps
Expand Down
Loading