Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions to API metadata & autogenerate index page metadata #2241

Merged
merged 58 commits into from
Nov 6, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

An issue with our API docs is confusing which version specific pages correspond to because we have so many duplicates. That is especially an issue with SEO, but also rich previews & tab titles. So, this PR adds the version to both the title and description.

We use minor versions rather than patch versions because search engines can be slow to update and we don't want their metadata to be out-of-date. Likewise, we call it (latest version) and (dev version) for this same reason.

Finally, this PR automates setting metadata for the index page whereas before we hardcoded it.

@Eric-Arellano
Copy link
Collaborator Author

CI fails on this because pagesRender has too many changed files

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, looks great!

@Eric-Arellano Eric-Arellano merged commit aa8e078 into main Nov 6, 2024
2 of 3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/index-page-metadata branch November 6, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants