Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert api-redirect-data.json #2154

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Revert api-redirect-data.json #2154

merged 1 commit into from
Oct 21, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Reverts #2125. Turns out, we didn't need to take that approach so we can instead use the simpler generateHistoricalRedirects.ts.

@frankharkins
Copy link
Member

We still need the custom redirects in the new file, right?

@Eric-Arellano
Copy link
Collaborator Author

We still need the custom redirects in the new file, right?

Those already exist via generateHistoricalRedirects.ts. I was recreating them.

frankharkins
frankharkins approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice, thanks

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit fc4f271 Oct 21, 2024
3 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/revert-api-data branch October 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankharkins frankharkins frankharkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Docs Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric-Arellano @frankharkins