Restore Options changes (revert #1722) #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 743c214. Co-authored-by: Arnau Casau <[email protected]> Co-authored-by: Ian Hincks <[email protected]> Co-authored-by: Jessie Yu <[email protected]>
|
One or more of the following people are relevant to this code:
|
Merged
jyu00
reviewed
Jul 16, 2024
| @@ -302,7 +302,7 @@ | |||
| "title": "Configure runtime options", | |||
There was a problem hiding this comment.
Should this be "configure primitive options"? Since it's under the "primitives" topic 🤔
There was a problem hiding this comment.
Should this be "configure primitive options"? Since it's under the "primitives" topic 🤔
Hmm - but we do at least mention other primitives (not just runtime) in the other section, and this is specifically about runtime options.
jyu00
reviewed
Jul 17, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…A/restore-options-pr
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
Co-authored-by: abbycross <[email protected]>
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
reviewed
Jul 31, 2024
abbycross
approved these changes
Jul 31, 2024
beckykd
reviewed
Jul 31, 2024
beckykd
reviewed
Jul 31, 2024
Co-authored-by: abbycross <[email protected]>
Co-authored-by: abbycross <[email protected]>
Co-authored-by: abbycross <[email protected]>
Co-authored-by: abbycross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1416
Closes #1453
Closes #1247
Closes #1529
This reverts commit 5f45f0f.
Accidentally closed #1499