Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in content for additional resources tab #1718

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Conversation

abbycross
Copy link
Collaborator

Closes #1698

@abbycross abbycross changed the title Fill in content for additional resources tab [WIP] Fill in content for additional resources tab Jul 16, 2024
@abbycross
Copy link
Collaborator Author

I see that when you click on the contributor or corporate license agreements items in the left nav, PDF files automatically open up outside the browser. Is there an icon we can use in the left nav to indicate that? A download icon or at least the external link one? What do you think @Eric-Arellano @gracelindsell
Screenshot 2024-07-16 at 1 15 59 PM

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ik it's a wip - pardon if you already knew this feedback)

FYI I've asked Luciano if he can write 1-2 paragraphs for open-source/index.mdx. We'll also need metadata for that file.

docs/open-source/qiskit-sdk-version-strategy.mdx Outdated Show resolved Hide resolved
docs/guides/install-qiskit.mdx Outdated Show resolved Hide resolved
@Eric-Arellano
Copy link
Collaborator

Is there an icon we can use in the left nav to indicate that? A download icon or at least the external link one?

Yeah, I was hoping the external link icon (up-right arrow) would Just Work. I have to figure out how to get it to work. I'll open an issue in closed source.

@abbycross
Copy link
Collaborator Author

Since we aren't doing migration guides yet, I think the only piece missing is the content and metadata for the open-source intro file (and a review of this PR).

@abbycross abbycross marked this pull request as ready for review July 17, 2024 18:11
@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

@abbycross
Copy link
Collaborator Author

I've moved the responsible-quantum-computing file into this PR to streamline efforts. @javabster approved that file in #1670

@abbycross abbycross self-assigned this Jul 17, 2024
@Eric-Arellano Eric-Arellano changed the title [WIP] Fill in content for additional resources tab Fill in content for additional resources tab Jul 17, 2024
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is safe infra-wise to merge now. It won't go live yet.

docs/guides/install-qiskit.mdx Outdated Show resolved Hide resolved
@abbycross abbycross added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit ab54d22 Jul 17, 2024
3 checks passed
@abbycross abbycross deleted the ajc/additional-resources branch July 17, 2024 18:59
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ NEW PAGE ] add pages to additional resources tab
3 participants