Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PR previews #1697

Merged
merged 13 commits into from
Jul 13, 2024
Merged

Clean up PR previews #1697

merged 13 commits into from
Jul 13, 2024

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Jul 12, 2024 •
edited
Loading

Adds a script and action to delete PR previews for closed PRs. See 3a29f15 for an example.

@frankharkins frankharkins linked an issue Jul 12, 2024 that may be closed by this pull request
Add cleanup for PR previews #1692
Closed
@frankharkins
Revert test commits
e0aa374 
This reverts commits:
 * 45ba56e
 * b8f9e29
@frankharkins frankharkins marked this pull request as ready for review July 12, 2024 14:37
Eric-Arellano
Eric-Arellano reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

scripts/pr_previews/utils.py Show resolved Hide resolved
Eric-Arellano
Eric-Arellano approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find with git checkout vs git switch! Could you please fix the raise SystemExit() in run_subprocess to be raise SystemExit(1)`? I realized we haven't been setting the exit code correctly, which messes up GH Actions.

scripts/pr_previews/cleanup.py Outdated Show resolved Hide resolved
scripts/pr_previews/cleanup.py Outdated Show resolved Hide resolved
@frankharkins
Copy link
Member Author

Good call with the exit code, I wondered why the action continued

Eric-Arellano
Eric-Arellano approved these changes Jul 12, 2024
View reviewed changes
scripts/pr_previews/utils.py Outdated Show resolved Hide resolved
scripts/pr_previews/utils.py Outdated Show resolved Hide resolved
@frankharkins @Eric-Arellano
Fix type hints
44fff28 
Co-authored-by: Eric Arellano <[email protected]>
@Eric-Arellano Eric-Arellano added this pull request to the merge queue Jul 13, 2024
Merged via the queue into main with commit 1ae2ef3 Jul 13, 2024
1 check passed
@Eric-Arellano Eric-Arellano deleted the FH/pr-cleanup branch July 13, 2024 13:53
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
@frankharkins @Eric-Arellano
Clean up PR previews (Qiskit#1697)
7c1ec09 
Adds a script and action to delete PR previews for closed PRs. See
ce7e3fb for an example.

---------

Co-authored-by: Eric Arellano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Docs Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cleanup for PR previews
2 participants
@frankharkins @Eric-Arellano