Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JijieZou add personal VerifyMotto #3

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

AsymmetryChou
Copy link
Contributor

@AsymmetryChou AsymmetryChou commented Sep 27, 2023

With #4 I finish the homework according to the requirements.

  • add personal verifyMotto function with unittest
  • add corresponding CI/CD

@QG-phy
Copy link
Owner

QG-phy commented Sep 27, 2023

  1. hard to recognize zjj. please sign your name fully spelled.
  2. you did not add a new issue and attach it to this PR.
  3. there are confilts, please resolve it!

@QG-phy
Copy link
Owner

QG-phy commented Sep 27, 2023

The title of this PR is too vague

@AsymmetryChou AsymmetryChou changed the title zjj first test JijieZou add personal VerifyMotto Sep 27, 2023
@AsymmetryChou
Copy link
Contributor Author

I have fixed the conflicts in my PC and git push to origin. As expected, the PR automatically fixs the conflict.

@@ -5,7 +5,7 @@
def verifyMotto(P: argparse.Namespace):
name = P.name
motto = P.motto
is_verified = False
is_verified = True
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么改成默认 True?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh!Just for test, a stupid mistake~

def verifyMottoJijieZou(public_string: str) -> bool:
'''

Verify if a public string is Qiangqiang Gu's motto.
Copy link
Owner

@QG-phy QG-phy Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your docstring is not right

@QG-phy QG-phy merged commit 5293292 into QG-phy:main Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants