-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JijieZou add personal VerifyMotto #3
Conversation
|
The title of this PR is too vague |
I have fixed the conflicts in my PC and git push to origin. As expected, the PR automatically fixs the conflict. |
dplc/motto/motto.py
Outdated
@@ -5,7 +5,7 @@ | |||
def verifyMotto(P: argparse.Namespace): | |||
name = P.name | |||
motto = P.motto | |||
is_verified = False | |||
is_verified = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么改成默认 True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh!Just for test, a stupid mistake~
dplc/motto/motto.py
Outdated
def verifyMottoJijieZou(public_string: str) -> bool: | ||
''' | ||
|
||
Verify if a public string is Qiangqiang Gu's motto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your docstring is not right
With #4 I finish the homework according to the requirements.