Feature/gamesreleasedtoday #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 20, 2021 17:28
…eature/gamesreleasedtoday Merging develop
Gonzom
reviewed
Feb 24, 2021
app/templates/partials/calendar/feature_settings/game_release_modal.html
Outdated
Show resolved
Hide resolved
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
yammesicka
requested changes
Feb 25, 2021
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
app/templates/partials/calendar/feature_settings/games_list.html
Outdated
Show resolved
Hide resolved
Comment on lines
134
to
137
| current_user_settings.update(games_setting_true) | ||
| session.commit() | ||
| else: | ||
| create_model(session, UserSettings, **games_setting_true_for_model) |
There was a problem hiding this comment.
So i did now but I can't really figure it out, it keeps creating new rows(I think it goes by primary key which is just an incremental id.
Didn't find a way to only update it without duplication other than update.
for now changed it back to update.
app/templates/partials/calendar/feature_settings/game_release_modal.html
Show resolved
Hide resolved
yammesicka
requested changes
Feb 26, 2021
app/static/js/game_releases.js
Outdated
| return response.text(); | ||
| }) | ||
| .then(function (body) { | ||
| document.querySelector("#content-div").innerHTML = body; |
There was a problem hiding this comment.
I'm not sure it would work here, wouldn't I be lacking formatting?
added 3 commits
February 26, 2021 19:01
Codecov Report
@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
- Coverage 95.27% 94.02% -1.26%
===========================================
Files 80 93 +13
Lines 3664 4416 +752
===========================================
+ Hits 3491 4152 +661
- Misses 173 264 +91
Continue to review full report at Codecov.
|
added 2 commits
March 27, 2021 13:30
…eature/gamesreleasedtoday
…d changed requests to httpx
added 2 commits
March 30, 2021 03:29
…d changed requests to httpx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added games released today functionality, currently enabled always, will be added to settings once done