Feature/timer #244

fandomario · 2021-02-09T01:01:50Z

Countdown timer to next event
https://forums.pythonic.guru/t/the-final-countdown/8915

* feat: add i18n support This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks. By: Gonny <1@1>

…rse#161) This reverts commit 779de2d.

@hadaskedar2020

* update ORM and added export for an event * update ORM and added export for an event * Added in app shareable events * docs: add type annotation and fix folder structure * docs: add type annotation and fix folder structure * docs: fix documentation * feat: get weather forecast for date and location * feat: get weather forecast for date and location * add: tests * set up commit * add: timezone support * add: session management * fix bug * split conftest file * split conftest file * move "utils" folder into "internal" folder * working day view with jinja2 template * with tests for pytest * feat: get weather forecast - fixes according to requested changes. * change file structure * feat: get weather forecast - fixes according to requested changes. * first functioning day-view html, css and router * feat: Basic responsive calender day view page Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. * feat: Basic responsive calender day view page Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. fixed after taking notes. * fix lint now for sure * more lint * feat: get weather forecast - fix requirements.txt * feat: enable invited users to view events * feat: flake8 changes * fix: requirements bug * fix: requirements bug * feat: flake8 changes * add: tests * feat: flake8 changes * add: tests * feat: flake8 changes * edit: file structure * edit: file structure * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * feat: add route tests * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * fix: test bug * remove: config.py * after all notes and started use the orm * fix: type annotation * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * fixed: changed "size" var in html and and more acuurate typing * deleted some testing lines * add requirements missing * add: minor changes * feat: flake8 changes * @hadaskedar2020 * feat: get weather forecast - add API mocking * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * fixed: statements of event select more accurate * new test and lint fix * added more contants abd more notes taken * feat: weather forecast - move feat to internal * Delete Scripts directory * update constants * more notes * forgot white space * feat: gets a link to the suitable image of a given event content. (PythonFreeCourse#70) * feat: gets a link to the suitable image of a given event content. * Add basic update event (PythonFreeCourse#100) * Add basic update event * Added search feature (PythonFreeCourse#98) * Added search feature * Add telegram client (PythonFreeCourse#111) Add telegram client * feat: Add a feature for sharing information with a WhatsApp account (PythonFreeCourse#83) * feat: Add a feature to share to a WhatsApp account * Feature/logging system (PythonFreeCourse#112) * feat: first logging commit Co-authored-by: Liad Noam <[email protected]> * feat: add a daily inspirational quote (PythonFreeCourse#128) * feat: add a daily inspirational quote * Feature/delete event (PythonFreeCourse#139) * basic delete event * Add an event delete function * Fix flake8 * Deleting an unnecessary model * Extract lines from try * fix: modify psycopg2 dependency (PythonFreeCourse#164) * Bugfix/logging system (PythonFreeCourse#158) * Changed logging config to be received by separate parameters for simplicity, removed option to receive configuration as a dict, added .vscode to gitignore * removed logging_config file which is no longer needed * Fixing merge conflicts - missing whitespace on config.py.example Co-authored-by: Liad Noam <[email protected]> * Added checking for zoom link and saving the event (PythonFreeCourse#122) * Added checking for zoom link and saving the event * Feature/import to calendar (PythonFreeCourse#119) * feat: import file to calendar * docs: adding community standard documents (PythonFreeCourse#173) * Feat: Event View Backend (PythonFreeCourse#159) * Moved the route to top of file * Feature/send email (PythonFreeCourse#88) * Added files for sending invitations by email This includes - templates - routes and internal code - configuration - tests Co-authored-by: leddest <[email protected]> Co-authored-by: Ellen <[email protected]> * Feature/translation - add an functionality to translate event data etc. (PythonFreeCourse#167) * translation feature stuff * Update event - Improving the code (PythonFreeCourse#138) * Add basic update event * Support categories for events (PythonFreeCourse#137) * Support categories for events * Style/grid (PythonFreeCourse#106) * Hello Wrold * Creating Html Template * Calendar dates calculation intigrating with html, HTML\CSS improvments. * Tests for calender_grid.py, changing function according to currections, fixing bugs * linting bug fixing * before merge with develop * Creating a Day object and days subclasses, changing all function and tests according to the new objects, Changing front to get information from Day objects, Re-arranging calendar.html grid stracture to be render by weeks, adding js functionality for day view section, adding css effects on daily event display * fix lintings * fix lintings * tests next week scroll * js updates * Calendar Scrolling with javascript * Fix lintings * Fix lintings * Calendar infinit scrolling ducplicates weeks bug fixed * seetings global parameters for calendar.py * Js - changing to fetch, removing jquery, fixing hint tpying, adding Week object, changing tests * Front end bug fixing * Fix linting * Fix lintings * Fix lintings * fixing syntax * Get user local date and time when enter calendar. * Fix lintings * Fix lintings * Fix lintings * Bugs fixing * Bugs fixing * Bugs fixing * Bugs fixing * JS alerts removal * Fix Lintings * Js syntext fixing * Bugs fixing * Bugs fixing * Js fixing varibales and adding div element to request. * Develop Update * Js - eliminate global parameters * Linting fixing * Fix Lintings * Fix flake8 * syntac fixing * Feature/translations workflow (PythonFreeCourse#150) * feat: add translations workflow * fix(translations-workflow): fix doc * fix(translations-workflow): fixed code and added automatic commit Co-authored-by: Gonny <1@1> * Revert "Feature/translations workflow (PythonFreeCourse#150)" (PythonFreeCourse#208) This reverts commit 2e6a2c2. * feat: Add zodiac signs to the day & month view + refactor json data loader (PythonFreeCourse#155) * feat: Add zodiac signs to the day/month view + * Change calendar link from '#' to '/' to get the home page (PythonFreeCourse#194) when clicking on the logo * Style/grid (PythonFreeCourse#200) * Js scrolling duplication days fixed Co-authored-by: Idan Pelled <[email protected]> Co-authored-by: Hadas Kedar <[email protected]> Co-authored-by: Sagi Zaid Or <[email protected]> Co-authored-by: sagizaidor <[email protected]> Co-authored-by: hadaskedar2020 <[email protected]> Co-authored-by: nir9696 <[email protected]> Co-authored-by: efratush <[email protected]> Co-authored-by: advaa123 <[email protected]> Co-authored-by: leddest <[email protected]> Co-authored-by: nelliei <[email protected]> Co-authored-by: Liad-n <[email protected]> Co-authored-by: Liad Noam <[email protected]> Co-authored-by: zohary89 <[email protected]> Co-authored-by: Ron Huberfeld <[email protected]> Co-authored-by: Ap1234567 <[email protected]> Co-authored-by: Nir-P <[email protected]> Co-authored-by: Ode <[email protected]> Co-authored-by: Anna Shtirberg <[email protected]> Co-authored-by: Ellen <[email protected]> Co-authored-by: ivarshav <[email protected]> Co-authored-by: Aviad <[email protected]> Co-authored-by: Gonzom <[email protected]> Co-authored-by: Gonny <1@1> Co-authored-by: YairEn <[email protected]>

…into feature/timer

yammesicka

That's a good start :) Let's start improving the JS

app/templates/profile.html

app/static/timer.js

codecov-io · 2021-02-17T19:01:43Z

Codecov Report

Merging #244 (085957b) into develop (919f2b1) will decrease coverage by 0.06%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    98.03%   97.96%   -0.07%     
===========================================
  Files           70       70              
  Lines         3000     3003       +3     
===========================================
+ Hits          2941     2942       +1     
- Misses          59       61       +2

Impacted Files	Coverage Δ
app/main.py	`92.50% <ø> (ø)`
app/routers/timer.py	`77.77% <77.77%> (ø)`
app/internal/timer.py	`100.00% <100.00%> (ø)`
app/database/models.py	`96.70% <0.00%> (-0.08%)`	⬇️
app/routers/salary/config.py	`100.00% <0.00%> (ø)`
app/internal/json_data_loader.py	`100.00% <0.00%> (ø)`
app/routers/joke.py
app/internal/jokes.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919f2b1...af7c971. Read the comment docs.

…into feature/timer

yammesicka

Great progress :) Added few insights

app/internal/timer.py

app/routers/timer.py

app/templates/profile.html

app/static/timer.js

tests/test_timer.py

…into feature/timer

yammesicka

Great job!

app/static/timer.js

app/internal/timer.py

yammesicka · 2021-02-21T10:21:41Z

app/routers/timer.py

+
+@router.get("/timer")
+def timer(request: Request, session=Depends(get_db)):
+    user = session.query(User).filter_by(id=1).first()


This route queries the event of the user. It can make the system go really slow.

Prefer to use Depends(current_user) from Kobi's login system to get the user details without querying the database.

[Optional]: To make this commit merge-ready, add last_added_event to the localStorage. If it exists, take it from the localStorage and Voilà! You don't have to access the database (you don't even have to send requests to the server). If it doesn't, query and add it to the localStorage. Note that you need to update the localStorage if the user add a new event.

Done :)

The countdown timer is counting till the current user's next event and not necessarily to the last added event.

I understand it. The note means to veck if the new event becomes the last event. If it does, it should replace the next event in the localStorage

Gonzom and others added 12 commits January 30, 2021 21:04

Revert "feat: add i18n support (PythonFreeCourse#115)" (PythonFreeCou…

6370ef2

…rse#161) This reverts commit 779de2d.

fix: tests

b587f6c

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

53bca85

…into feature/timer

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

079e6f5

…into feature/timer

feat: countdown timer to next event on profile page

8bb9b1e

fix: flake8

c91fbf0

fix: flake8 2

66eed5d

fix: flake8 3

7d74135

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

38a47e2

…into feature/timer

fix: fix bugs in routers\event.py and in config,py

92c6f00

yammesicka requested changes Feb 9, 2021

View reviewed changes

fandomario added 2 commits February 17, 2021 19:23

fix: fix variables names

d82d950

fix: according to the CR

0c98206

fandomario added 2 commits February 17, 2021 21:16

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

5531a43

…into feature/timer

fix: fix tests

d3ea415

yammesicka requested changes Feb 18, 2021

View reviewed changes

fandomario and others added 2 commits February 18, 2021 22:34

fix: according to CR

bc58d93

Merge branch 'develop' into feature/timer

c75f2ba

fandomario requested a review from yammesicka February 18, 2021 20:57

yammesicka requested changes Feb 19, 2021

View reviewed changes

app/templates/profile.html Outdated Show resolved Hide resolved

app/static/timer.js Outdated Show resolved Hide resolved

app/static/timer.js Outdated Show resolved Hide resolved

tests/test_timer.py Outdated Show resolved Hide resolved

fandomario added 3 commits February 20, 2021 06:14

fix: according to CR

fa6d739

Merge branch 'feature/timer' of https://github.com/fandomario/calendar …

b56f3da

…into feature/timer

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

af7c971

…into feature/timer

fandomario requested a review from yammesicka February 20, 2021 04:33

fandomario added 2 commits February 20, 2021 22:32

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

a11cb5a

…into feature/timer

fix: fix a bug after QA :)

cc29fc1

yammesicka requested changes Feb 21, 2021

View reviewed changes

fandomario added 2 commits February 22, 2021 03:40

fix: improoving query, adding current_user

91e85bb

fix: fix conflicts

2823cae

fandomario requested a review from yammesicka February 22, 2021 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/timer #244

Feature/timer #244

fandomario commented Feb 9, 2021

yammesicka left a comment

codecov-io commented Feb 17, 2021 •

edited

Loading

yammesicka left a comment •

edited

Loading

yammesicka left a comment

yammesicka Feb 21, 2021

fandomario Feb 22, 2021 •

edited

Loading

yammesicka Feb 23, 2021

Feature/timer #244

Are you sure you want to change the base?

Feature/timer #244

Conversation

fandomario commented Feb 9, 2021

yammesicka left a comment

Choose a reason for hiding this comment

codecov-io commented Feb 17, 2021 • edited Loading

Codecov Report

yammesicka left a comment • edited Loading

Choose a reason for hiding this comment

yammesicka left a comment

Choose a reason for hiding this comment

yammesicka Feb 21, 2021

Choose a reason for hiding this comment

fandomario Feb 22, 2021 • edited Loading

Choose a reason for hiding this comment

yammesicka Feb 23, 2021

Choose a reason for hiding this comment

codecov-io commented Feb 17, 2021 •

edited

Loading

yammesicka left a comment •

edited

Loading

fandomario Feb 22, 2021 •

edited

Loading