Adding python build, lint and test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 5, 2021 15:44
upkarlidder
changed the title
upkarlidder
commented
Jun 6, 2021
| @@ -223,7 +223,7 @@ def __init__(self, list_of_csv_files=None, config_filename=DEFAULT_CONFIG_FILENA | |||
| dataframes = [] | |||
| for csv_file in list_of_csv_files : | |||
| df = pd.read_csv(csv_file, engine='python', parse_dates=[TIMESTAMP_COL], index_col = TIMESTAMP_COL) | |||
| assert FIREFIGHTER_ID_COL in df.columns, "CSV files is missing key columns %s" % (required_cols) | |||
| # assert FIREFIGHTER_ID_COL in df.columns, "CSV files is missing key columns %s" % (required_cols) | |||
There was a problem hiding this comment.
Commented out the code for now. Checking with @JSegrave-IBM. Created #38 for @TaeBlack @Aquijada52
upkarlidder
commented
Jun 6, 2021
| websocket-client==0.57.0 | ||
| coverage==5.5 |
There was a problem hiding this comment.
Added coverage that shows what code is being tested with the tests.
|
@krook this PR adds
I have removed the IBM toolchain. I will add GitHub action to build and deploy to our cluster next. |
krook
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.