Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more cases too covered all possible Marttra #929

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

HRNPH
Copy link
Contributor

@HRNPH HRNPH commented Oct 26, 2024

What does this changes

Add more testcase to covered all mattra to ensure the function was working properly

What was wrong

The testcase in pythainlp.khavee module didn't covered all Mattra

How this fixes it

  • Add all mattra cases to cover for กกา, แม่กก, แม่กง, แม่กด, แม่กน, แม่กบ, แม่กม, แม่เกย, แม่เกอว
  • All Case added was referenced from this article

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Oct 26, 2024

Hello @HRNPH! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 15:34: W291 trailing whitespace
Line 16:57: W291 trailing whitespace
Line 17:55: W291 trailing whitespace

Comment last updated at 2024-10-27 06:39:53 UTC

Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wannaphong wannaphong added the hacktoberfest-accepted hacktoberfest accepted pull requests. label Oct 26, 2024
Copy link

@bact bact merged commit 461fe88 into PyThaiNLP:dev Oct 27, 2024
7 of 12 checks passed
@bact
Copy link
Member

bact commented Oct 27, 2024

Thank you merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest accepted pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants