Don't test against python 3.7 in ci #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also explicitly setup python for any job that needs to use pip, since python 3.12 on the latest ubuntu fails when trying to install in a system package directory.
|
I'm confused by the observation that it's unavailable, because 3.7 installs fine in the PyO3 CI: https://github.com/PyO3/pyo3/actions/runs/11152546510/job/30998379433#step:3:17 |
|
That said, I would be happy if we added a runtime check for minimum Python version of 3.9, if we were to complete things in the spirit of #445. (And we should mention in the CHANGELOG.) |
|
Not sure why this was failing for me, but glad to see that python 3.7 is still working in ci. I will close this, and we can address bumping the minimum supported python version separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 is no longer available for
ubuntu-latest, so drop it from the ci matrix. I've also added explicitsetup-pythonsteps for any job that needs to use pip, since python 3.12 on the current version ofubuntu-latestfails when trying to install in a system package directory. This is somewhat related to #445, though there may be other things we need to do in order to drop support for older pythons.