Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDM & SGE] Tweaks #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[RDM & SGE] Tweaks #311

wants to merge 3 commits into from

Conversation

Tartarga
Copy link
Contributor

  • All

    • Removed actionID passing to CanUseLucid (SGE/RDM/SCH/WHM calls updated)

  • SGE

    • Removed Ignore AoE Shield Check. Eukrasia Prognosis moved to priority system. Slider checks for total shields (Diagnosis/Prognosis)

  • RDM

    • Cleanup, removed passing of actionID to all rotation functions execpt TryOGCDs. Reduced variables (out to ref) from rotation functions.
    • Prioritized Preflugence in TryOGCDs
    • Prevented Double CorpACorps or Engagments in the same oGCD window (Discord Report)
    • Delayed Vice of Thorns until (hopefully) the next oGCD window (Discord Report)

@Tartarga
[RDM & SGE] Tweaks
e4e3655 
All: Removed actionID passing to CanUseLucid (SGE/RDM/SCH/WHM calls updated)
SGE
- Removed Ignore AoE Shield Check. Eukrasia Prognosis moved to priority system. Slider checks for total shields (Diagnosis/Prognosis)
RDM
- Cleanup, removed passing of actionID to all but TryOGCDs. Reduced variables (out to ref) from rotation segment functions.
- Prioritized Preflugence in TryOGCDs
- Prevented Double CorpACorps or Engagments in the same oGCD window (Discord Report)
- Delayed Vice of Thorns until (hopefully) the next oGCD window (Discord Report)
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 24, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  WrathCombo/Combos/PvE/SGE/SGE_Config.cs  46% smaller
  WrathCombo/Combos/PvE/RDM/RDM_Helper.cs  19% smaller
  WrathCombo/Combos/PvE/SGE/SGE_Helper.cs  15% smaller
  WrathCombo/Combos/PvE/SCH/SCH.cs  10% smaller
  WrathCombo/Combos/PvE/WHM/WHM.cs  10% smaller
  WrathCombo/Combos/PvE/ALL/ALL.cs  3% smaller
  WrathCombo/Combos/PvE/SGE/SGE.cs  1% smaller
  WrathCombo/Combos/CustomComboPreset.cs  0% smaller
  WrathCombo/Combos/PvE/RDM/RDM.cs  0% smaller
  WrathCombo/Combos/PvE/RDM/RDM_Config.cs  0% smaller

@Tartarga Tartarga mentioned this pull request Jan 24, 2025
Closed
Taurenkey
Taurenkey reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Taurenkey Taurenkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some weaves added to the RDM code? It's not checking for them so you end up sitting on oGCDs which can cause clipping.

@Tartarga
Copy link
Contributor Author

WrathCombo/WrathCombo/Combos/PvE/RDM/RDM_Helper.cs

Line 141 in e4e3655

if (!CanSpellWeave()) return false;

The oGCD selector function should be exiting right at the beginning if it cannot spellweave the oGCDs

@Taurenkey
Copy link
Contributor

This hasn't been applied to Accelerate

@Akechi-kun Akechi-kun added Optimization Similar to suggestion, but solely for increasing performance Adjustments This will adjust something inside a rotation, feature, or core function labels Feb 3, 2025
zbee
zbee approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@zbee zbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested have been made, and otherwise looks tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taurenkey Taurenkey Taurenkey left review comments

@zbee zbee zbee approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Adjustments This will adjust something inside a rotation, feature, or core function Optimization Similar to suggestion, but solely for increasing performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tartarga @Taurenkey @zbee @Akechi-kun