Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional startup message config #66

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add optional startup message config #66

merged 2 commits into from
Sep 26, 2024

Conversation

n0ky4
Copy link
Contributor

@n0ky4 n0ky4 commented Sep 25, 2024

πŸ«€ Add optional startup message config

πŸ§‘β€πŸ« Description

Some users want to disable the default startup message to add their own. I added the showStartupMessage config and changed the showBanner config to startupMessageFormat, which now accepts two literal arguments (banner | simple)

export interface Options {
  config?: {
    customLogFormat?: string
    logFilePath?: string
    logFilter?: {
      level?: LogLevel | LogLevel[]
      method?: string | string[]
      status?: number | number[]
    } | null
    ip?: boolean
    useColors?: boolean
-   showBanner?: boolean
+   showStartupMessage?: boolean
+   startupMessageFormat?: 'banner' | 'simple'
    transports?: Transport[]
  }
}

πŸ“ Checklist

  • I have tested the changes locally.
  • I have added tests for the changes.
  • I have updated the documentation accordingly.

Copy link

codesandbox bot commented Sep 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor β€’ VS Code β€’ Insiders

Open Preview

@PunGrumpy
Copy link
Owner

Thank u for pr ❀️

@PunGrumpy PunGrumpy added the enhancement πŸ’« New feature or request label Sep 26, 2024
@PunGrumpy
Copy link
Owner

Can u update in example/basic.ts?

@github-actions github-actions bot added the source 🏠 Source code files label Sep 26, 2024
Copy link
Owner

@PunGrumpy PunGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!! πŸ’―

@PunGrumpy PunGrumpy self-assigned this Sep 26, 2024
@PunGrumpy PunGrumpy merged commit b68696f into PunGrumpy:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement πŸ’« New feature or request source 🏠 Source code files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants